- ๐ฎ๐ณIndia ajeet_kumar gurugaon
I verified patch there is not included Drupal 10 compatibility changes in module info file.
- First commit to issue fork.
- @snap_x opened merge request.
- Status changed to Needs review
over 1 year ago 2:42pm 11 May 2023 - ๐บ๐ฆUkraine snap_x
I checked the patch #5 and it isn't correct because after Drupal Rector's changes module isn't compatible with D8 anymore. Here is a change record https://www.drupal.org/node/3159012 โ that was applied by Drupal Rector.
So I created new MR with compatibility only for ^9 || ^10. - First commit to issue fork.
- Status changed to RTBC
over 1 year ago 6:58pm 26 July 2023 - ๐บ๐ธUnited States mlncn Minneapolis, MN, USA
Using the latest merge request in production.
- ๐บ๐ธUnited States sassafrass
Successfully using latest merge request in production. Thanks!
- ๐ง๐ฌBulgaria nikolabintev
Hi all! Thank you for your effort. We are going to review the suggested changes and prepare a stable release shortly.
- ๐ง๐ฌBulgaria Nikolay Penchev
Nikolay Penchev โ made their first commit to this issueโs fork.
- ๐ง๐ฌBulgaria Nikolay Penchev
In this commit, I've upgraded the usage of Symfony\Contracts\EventDispatcher\Event to Drupal\Component\EventDispatcher\Event, aligning with this article: https://www.drupal.org/node/3159012 โ . This change ensures Drupal 9/10 compatibility and forward compatibility with Symfony 5.
Additionally, I've executed the PHP Code Sniffer and Drupal Check tools to validate the code against coding standards, ensuring the codebase remains clean and maintainable. - @nikolay-penchev opened merge request.
- @nikolay-penchev opened merge request.
-
nikolabintev โ
committed 17dfffc5 on 8.x-2.x authored by
Nikolay Penchev โ
Issue #3286947 by java008, Nikolay Penchev, snap_x, ajeet_kumar,...
-
nikolabintev โ
committed 17dfffc5 on 8.x-2.x authored by
Nikolay Penchev โ
- ๐ง๐ฌBulgaria nikolabintev
Thank you, everyone, for the effort! I am closing the issue.
- Status changed to Fixed
over 1 year ago 5:14am 2 August 2023 - ๐จ๐ฆCanada dalin Guelph, ๐จ๐ฆ, ๐
If you could cut a new release of the module, that'd be great! Unfortunately it's not possible to use a patch to make a module's composer.json file to be compatible with D10.
- ๐ง๐ฌBulgaria nikolabintev
Hi @dalin,
There's one more issue that we'd like to fix first and then we will release a stable version. You can still apply the patch by using the drupal lenient package. Check this โ
Automatically closed - issue fixed for 2 weeks with no activity.