Thanks @loon for the patch. It works fine for me.
I provided a fix to keep the anchor context.
I've provided the fix.
@AstonVictor Pull the latest changes from the dev branch please
I see that it is already fixed in the dev branch.
Thanks @AstonVictor
Changes look good
Thanks @o_tymoshchuk!
Changes look fine
Thanks @AstonVictor!
Changes look fine
Thanks @ViacheslavMiakota for the changes!
Looks fine
Thanks @Oleksandr P. for the changes.
Looks good
Thanks @AstonVictor!
Chnages look fine
Thanks @jollyoff!
Thanks @jollyoff for the changes.
Apply README.md styling, please. You can find some examples here https://docs.github.com/en/get-started/writing-on-github/getting-started... and test https://www.makeareadme.com/
Thanks, @ViacheslavMiakota for the changes!
MR looks fine.
Thanks @AstonVictor for the changes!
Looks good.
Thanks @AstonVictor!
The changes look fine.
Thanks @jollyoff. The changes look good.
snap_x → changed the visibility of the branch 3414994-sitesdirectoryhardeningtest-does-not to active.
snap_x → changed the visibility of the branch 3414994-sitesdirectoryhardeningtest-does-not to hidden.
The newest module version already supports Drupal 10.
+
@Nikolay Borisov Unfortunately I am not a maintainer of this module :)
You also can use a patch from the MR, just by adding .patch to the MR URL
+1 to RTBC
It works fine for me with patch #2
I also added missed changes to the issue’s fork and created MR.
I've improved the check to avoid warning and created MR
snap_x → created an issue.
Thanks for the patches.
+1 RTBC. Tested on Drupal 10 with patch from MR. Works perfectly for me.
Hah, true! I missed that as well. Thanks @laura.gates I also updated version according to the
change record →
, because changes aren't compatible
with Drupal <9.3
Thanks @laura.gates for the patch. According to the
change record →
drupal_get_path should be replaced by \Drupal::service('extension.list.module'), so I updated MR. The changes are identical as patch #2.
I tested and it works perfect for me.
+1 to RTBC. Works fine for me in Drupal 10. Also updated the MR according to the latest Drupal Rector's changes.
@neelam_wadhwani Seems that you missed to merge/add changes to the repository. There is no changes from this issue in any branch. Take a look please. Looking forward to D10 compatible release. Thanks!
Patch #2 works fine me on Drupal 10. I also created MR with needed changes.
New D10 release created