🇮🇳India @ajeet_kumar

gurugaon
Account created on 15 March 2023, over 1 year ago
#

Recent comments

🇮🇳India ajeet_kumar gurugaon

I have reviewed and tested the patch # opigno_learning_path_activities_listing_issue_3450789_1.patch Working for me and rowCount issue resolved.

🇮🇳India ajeet_kumar gurugaon

required jackmoore-colorbox library not installed

🇮🇳India ajeet_kumar gurugaon

I reviewed and tested patch #49 working for me

🇮🇳India ajeet_kumar gurugaon

changes added D10 compatibility changes into info.yml file

🇮🇳India ajeet_kumar gurugaon

I have applied patch #2 , it got applied successfully. and working with D10 latest version

🇮🇳India ajeet_kumar gurugaon

I have applied patch #2 , it got applied successfully. and working with D10 latest version

🇮🇳India ajeet_kumar gurugaon

I have applied patch #2 , it got applied successfully. and working with D10 latest version

🇮🇳India ajeet_kumar gurugaon

I have reviewed patch #5 , it got applied successfully. and working with D10 latest version

🇮🇳India ajeet_kumar gurugaon

I have applied patch #9 , it got applied successfully. and working with D10 latest version

🇮🇳India ajeet_kumar gurugaon

I have applied patch #2 , it got applied successfully. and working with D10 latest version.

🇮🇳India ajeet_kumar gurugaon

great patch #2 working fine and compatibility with drupal 10.

🇮🇳India ajeet_kumar gurugaon

Patch #20 reviewed and testing working and installed with Drupal 10 latest version.

🇮🇳India ajeet_kumar gurugaon

remove core require in info file in standard fixed

🇮🇳India ajeet_kumar gurugaon

Fixed drupal coder standard issue

🇮🇳India ajeet_kumar gurugaon

Fixed apply patch whitespace error

🇮🇳India ajeet_kumar gurugaon

I reviewed and tested and found issue with jQuery deprecated function"Uncaught TypeError: $(...).once is not a function" in drupal 10.

🇮🇳India ajeet_kumar gurugaon

I reviewed patch#3 is working fine . changing issues status to reviewed & tested by community.

🇮🇳India ajeet_kumar gurugaon

I have applied and tested the patch#6, its getting applied successfully.
There are no drupal check and upgrade status errors found.
The module is now compatible with Drupal 10, Issue status changed to RTBC.

🇮🇳India ajeet_kumar gurugaon

I have applied and tested the patch#6, its getting applied successfully.
There are no drupal check and upgrade status errors found.
The module is now compatible with Drupal 10, Issue status changed to RTBC.

🇮🇳India ajeet_kumar gurugaon

Drupal10 CKEditor_template CKEditor5 compatibility 3273358-48#51.patch
interdiff-3273358-48#51.txt

🇮🇳India ajeet_kumar gurugaon

@Chris64 I tested the version 1.10.21 for the JQuery DataTables library. Downloaded with composer , from https://packagist.org/packages/datatables/datatables. Working as Expected.

🇮🇳India ajeet_kumar gurugaon

I reviewed patch#2 also run drupal-check no error found and functionality working as expected.

🇮🇳India ajeet_kumar gurugaon

I reviewed with patch https://www.drupal.org/files/issues/2023-04-06/3273358-48.patch and found Drupal 10 deprecated issues as

..\contrib\ckeditor_templates\src\Form\CKEditorTemplatesDialogForm.php

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.. After resolving working as expected CKEditor.

🇮🇳India ajeet_kumar gurugaon

Drupal 10 compatibility 8.x-2.0-alpha5 version released.

🇮🇳India ajeet_kumar gurugaon

Project footnote Drupal 10 compatibility.

🇮🇳India ajeet_kumar gurugaon

Return type mixed of method Drupal\required_by_role\Tests\Plugin\Required\RequiredByRoleTest::setUp() is not covariant with return type void of method PHPUnit\Framework\TestCase::setUp().

🇮🇳India ajeet_kumar gurugaon

I reviewed patch with Drupal 10.0.7 It's working fine successfully login by email id. Changing issue status to Reviewed & Tested by the community.

🇮🇳India ajeet_kumar gurugaon

Patch verify and issue found

TypeError: array_filter(): Argument #1 ($array) must be of type array, string given in array_filter() (line 171 of C:\xampp\htdocs\patch_contribution\patch_contribution\web\modules\contrib\advpoll\src\Form\ApprovalPollViewForm.php).

. Issue fixed with patch

🇮🇳India ajeet_kumar gurugaon

I reviewed patch and found Drupal 10 compatibility issues.

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

🇮🇳India ajeet_kumar gurugaon

I reviewed patch#3 Drupal 10 compatibility and functionality working as expected.

🇮🇳India ajeet_kumar gurugaon

I reviewed patch#3 working with Drupal10 Compatibility. Entity Reference modal box also working and using this entity created successfully.

🇮🇳India ajeet_kumar gurugaon

I review patch#2hwith Drupal10.0.7 working fine for me also checked with drupal-check no issues found

🇮🇳India ajeet_kumar gurugaon

Working fine and compatibility with Drupal 10. Please review and release Drupal 10 compatibility version.

🇮🇳India ajeet_kumar gurugaon

I can confirm this patch#4 working as expected with Drupal 10 compatibility and I was able to perform the deletion, thank

🇮🇳India ajeet_kumar gurugaon

I reviewed and verify patch with 8.x.1.x version with Drupal 10 there is non ignorable issues found. Drupal 10 compatibility issues fixed.

🇮🇳India ajeet_kumar gurugaon

reviewed patch 3332020#3 and 2999400-8 working as Drupal 10 compatibility and merge patch . It's dependency to upgrade project to Drupal 10. Please keep jQuery dependency it issue with separate ticket and release D10 compatibility version.

🇮🇳India ajeet_kumar gurugaon

I have created patch for Drupal 10 compatibility. Please review

🇮🇳India ajeet_kumar gurugaon

Created patch for 8.x-1.x to fix Drupal 10 compatibility issues. Please review it.

🇮🇳India ajeet_kumar gurugaon

I have tested patch #9 on Drupal 10.0.5 which applied cleanly and working as expected. So, moving it to RTBC.
Once more then content added into content type also removed from configuration list because of more then 1 added content type cont configurable.

🇮🇳India ajeet_kumar gurugaon

I reviewed and verify patch with 8.x.1.x version with Drupal 10 there is non ignorable issues found. Drupal 10 compatibility issues fixed.

🇮🇳India ajeet_kumar gurugaon

I reviewed and verify functionality with Drupal 10 with 8.x branch it's working fine.

🇮🇳India ajeet_kumar gurugaon

I verified patch there is not included Drupal 10 compatibility changes in module info file.

🇮🇳India ajeet_kumar gurugaon

I checked and verified functionality working fine.

🇮🇳India ajeet_kumar gurugaon

I have verify and reviewed patch it's compatibility with drupal 10. But there is other deprecated function issue not fixed.
Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.
Please review patch.

🇮🇳India ajeet_kumar gurugaon

I have reviewed Patch/functionality on Drupal 9(9.5.7) and Drupal 10 (10.0.5). functionality working same as D9.
But max length module showing character limitation counter but field validation not working.
currently can save values more then max length defined in form field configuration.

🇮🇳India ajeet_kumar gurugaon

I run drupal-check query and found some issue with drupal-check. I have created this patch for fix drupal-check issues.

🇮🇳India ajeet_kumar gurugaon

ajeet_kumar created an issue.

Production build 0.69.0 2024