[10] Use QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked

Hi Team I have created D10 combability patch please review it.

Most of the patch is out of scope - only the first hunk is relevant. Please remove the excess changes. Also, please review the other issues in the queue if you want to help out with things like the guesser. See for example ✨ Improve image detection Needs work .

The deprecation notice does not show up in the automated D10 tests, so that means the code is not being tested. Please add a test.

Also please link the change record in the issue summary as documentation of what is being done here.

Here's a simple test case. This should pass on D9 but fail on D10 due to the accessCheck issue.

The last submitted patch, 4: 3350070-4-test-only.patch, failed testing. View results →

Evidently need to enable the 'field' module for functional tests ...

OK, where and how did you get that error message? Were you running the current -dev or a previous verision?

The reason I ask is that the change record Access checking must be explicitly specified on content entity queries → says that this is specifically for content entity queries and does not apply to configuration entities. But the only entity query in Mime Mail is a query of the field_config configuration entity, which shouldn't be affected.

And as you can see from the tests in #6 which run this query code, there is NO error reported either in D9 or D10. Leaving accessCheck() off a content entity query should throw an exception. Likewise, drupal-check and other tools do not point this out as a problem.

I run drupal-check query and found some issue with drupal-check. I have created this patch for fix drupal-check issues.

I'm going to commit my test because it demonstrates that Mime Mail is using the entity query properly, and because this will give us some minimal coverage for the AdminForm.

I don't see anything else in your patch that needs to be addressed.

Automatically closed - issue fixed for 2 weeks with no activity.