- πΊπΈUnited States tr Cascadia
Here's a re-roll of the patch in #2 against the current HEAD. I expect the tests will still fail for the reasons I described in #4, because nothing has been done to fix that.
The last submitted patch, 5: 3155325-5-type-guesser.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
almost 2 years ago 6:53am 18 February 2023 - πΊπΈUnited States tr Cascadia
Corrected two @var declarations to use the current version of Symfony.
- πΊπΈUnited States tr Cascadia
Have to also update
guess()
to beguessMimeType()
for D10. Becauseguess()
was deprecated in D9.1 this change will also work with our current minimum core version of 9.3.Note the fact that the D9 tests did not catch this is a direct result of our lack of testing for certain key methods. In this case,
guess()
is used inMimeMailFormatHelper::mimeMailFile
andMimeMailFormatHelper::mimeMailMultipartBody
, but neither of those are tested. See:
#3145400: Add test cases for MimeMailFormatHelper::mimeMailFile() β
#3145401: Add test cases for MimeMailFormatHelper::mimeMailMultipartBody() β - πΊπΈUnited States tr Cascadia
OK, #8 fixed the new errors related to
guess()
, so we're back to needing to fix the one test failure described in #4. - Status changed to Needs review
almost 2 years ago 10:21pm 7 March 2023 - πΊπΈUnited States tr Cascadia
Re-rolled against HEAD and included a fix for #4.
This issue is blocking a D10 release.
The last submitted patch, 10: 3155325-10-type-guesser.patch, failed testing. View results β
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- Status changed to Needs work
almost 2 years ago 11:04pm 7 March 2023 - πΊπΈUnited States tr Cascadia
Well that did fix the issue from #4 but it caused another issue, which I will now have to look into.
- First commit to issue fork.
- πΊπΈUnited States scott_earnest
Updates rolled into issue fork.
Unfortunately, PHPUnit is throwing an error, need to look into this:
https://git.drupalcode.org/issue/mimemail-3155325/-/jobs/2799865
---- Drupal\Tests\mimemail\Functional\MimeMailWebTest ----Otherwise this works for me in Drupal 10 and Drupal 11.
- πΊπΈUnited States jfurnas
Even with this patch in place, I am still getting the same error message related to using 'guess' as the method name.