- First commit to issue fork.
- @himanshu_jhaloya opened merge request.
- Status changed to RTBC
over 1 year ago 2:21pm 25 May 2023 - 🇮🇳India Chandra Gowsalya Kannan
Tested Above patch #2 which makes module D10 compatible. No non ignorable error found in drupal check. Found compatiblity status in upgrade status.
Screenshots attached for ref. Moving to RTBC !! - First commit to issue fork.
- 🇮🇳India ajeet_kumar gurugaon
I have applied patch #2 → , it got applied successfully. and working with D10 latest version
- 🇦🇹Austria crmn
i applied the patch, but i am not able to update drupal/core.
@ajeet_kumar did you require drupal 10 as another version? which one? - 🇨🇦Canada othermachines Edmonton, Alberta
Hi! Since Drupal 9 will be end-of-life in a matter of days can we get a release with this patch please?
- 🇨🇦Canada othermachines Edmonton, Alberta
@crmn Assuming you are using , the patch still won't be recognized when you run your code update. You will also need to require mglaman/composer-drupal-lenient then run:
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/video_embed_facebook"]'
The way I understand it, doing the above is instructing composer to be lenient with the version constraint when considering this package.
- 🇺🇸United States bas123
Can someone please summarize this solution?
If I am reading the patch correctly, all it is doing is to change the video_embed_facebook.info.yml to reflect "
core_version_requirement: ^8 || ^9 || ^10
"If that is the case, why cannot one simply edit the file directly?
If the additional solution includes the steps listed in #11 📌 Automated Drupal 10 compatibility fixes RTBC , then that is easy enough too.
My only goal is chipping away at a number of module obstacles that are preventing me from moving my site into Drupal 10!
- 🇪🇸Spain jonodunnett
This seems to work. I patched the 8.x-1.5 version rather than dev:
1. Include the patch provided by the project bot in your composer.json"extra": { "enable-patching": true, "composer-exit-on-patch-failure": true, "patchLevel": { "drupal/core": "-p2" }, "patches": { "drupal/video_embed_facebook": { "#3290373: Automated Drupal 10 compatibility fixes": "https://www.drupal.org/files/issues/2022-06-16/video_embed_facebook.1.x-dev.rector.patch" } }, .....
2. Run "composer update drupal/video_embed_facebook --no-cache"
3. On the Upgrade Status page re-scan the patched module to confirm all OK. - 🇧🇪Belgium stijnstroobants Leuven
Released a D10-compatible version this morning.
- Status changed to Fixed
about 1 year ago 12:13pm 2 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.