I am using your patch and that fixes it, thankyou IGhosh.
jonodunnett → created an issue.
I surprised myself.. The issue seems to be the one documented here https://www.drupal.org/project/drupal/issues/3055194 →
Calling the "Symfony\Component\EventDispatcher\EventDispatcherInterface::dispatch()" method with the event name as first argument is deprecated since Symfony 4.3, pass it second and provide the event object first instead.
I switched the order (put the $event first) at the four locations I found the method in \src\Manager\SinglePageSiteManager.php and that fixed the problem.
Here is the combined patch that is working for me on d10.
With the help of mglaman/composer-drupal-lenient and cweagans/composer-patches I can require and patch the module for my D10 project. The patch from #5 applies cleanly (and already contains the changes from #3 patch). Unfortunately, when I try to access the front page (the single page site) there is an error. In the Drupal log this is the error:
TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given, called in C:\wamp64\www\REPOS\D8-multi\httpdocs\modules\contrib\single_page_site\src\Manager\SinglePageSiteManager.php on line 277 in Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (line 89 of C:\wamp64\www\REPOS\D8-multi\httpdocs\core\lib\Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher.php).
Sorry but I don't have the expertise to diagnose further.
This seems to work. I patched the 8.x-1.5 version rather than dev:
1. Include the patch provided by the project bot in your composer.json
"extra": {
"enable-patching": true,
"composer-exit-on-patch-failure": true,
"patchLevel": {
"drupal/core": "-p2"
},
"patches": {
"drupal/video_embed_facebook": {
"#3290373: Automated Drupal 10 compatibility fixes": "https://www.drupal.org/files/issues/2022-06-16/video_embed_facebook.1.x-dev.rector.patch"
}
},
.....
2. Run "composer update drupal/video_embed_facebook --no-cache"
3. On the Upgrade Status page re-scan the patched module to confirm all OK.
Problems for me after update to D10 when one of my tabs contains a Webform.
- If Quicktab setting is to use Ajax, then the tabs show up but the content does not load properly when clicked ("Loading content..." message forever.)
- If Quicktab setting is to NOT use Ajax, then none of the tabs show up (not even the tab names).
Functionality returns if I delete the Webform tab. Worked fine with the Webform tab included before this D10 update.
jonodunnett → created an issue.