Adding patch for AccessCheck issue
Chandra Gowsalya Kannan → created an issue.
Updating patch to resolve render and comaptiblity issue
Updating patch to resolve drupal check errors and render issue
Chandra Gowsalya Kannan → created an issue.
I have applied rector patch in drupal 9.3 and drupal 10.0.3 , it is compatible with ckeditor 4.
Followed below steps:
1. Clone this module
2. Applied the patch.
3. Since it has dependency on ckeditor, hence downloaded contrib ckeditor module
4. Enable both ckeditor and ckeditor_blockquote_attribution
5. Drupal check not shown any error.
Please check attached screenshot
Moving this to RTBC !
Attaching before patch errors
After applying rector patch in #2 found few non-ignorable error when checking in drupal-check, due to which the module is not able to install.
Created updated patch which include fixes for drupal check errors.
Attaching patch and screenshot.
Reviewed the functionality in Drupal 10.0.4 site which works good.
I have applied the rector patch in drupal 9 site, and checked Upgrade status , found no error.
Attached ss for reference. Moving to RTBC
Updating the patch for latest version of paragraphs 1.16
Applied patch 11 in drupal 9 site, patch applied cleanly and not throwing any error and it compatible with D10.
Patch #11 is not compatible with D10, I have reviewed patch #14 in Drupal 9 site, it shows compatible with D10 with no error.
Please check screenshot.
Moving this to RTBC !!
updated patch 11 with few changes related to D10 compatiblity issue.
Kindly review it
The patch in comment #6 is used in our website where after upgrading to Drupal 10 as because there is no D10 release for this, there is few compatibility issue in some files, I changed it and created patch. Kindly review it
$show_count is returning null, hence modified with conditions and adding a patch.
This patch resolves above warning.
Chandra Gowsalya Kannan → created an issue.
Applied MR changes but still found few errors in drupal check . Resolved and created new patch.
It has dependency to webform and dropzonejs.
Attached screenshot for ref. No non ignorable error in drupal check
Tested the patch in Drupal 9 and Drupal 10. No non ignorable error found in drupal check and upgrade status.
Hope for latest stable release.
Tested the patch in Drupal 9 and Drupal 10. No error found in drupal check and it is compatible for D10. Attached screenshot.
Applied MR and checked in Drupal9 but still found non ignorable drupal check error. Resolved that in my patch.
Reviewed above patch #2 in drupal 9 and 10 which is making module D10 compatible and not found any error in drupal check and D10 upgrade status.
Attached screenshot for reference
Moving this to RTBC :)
Applied the merge request in Drupal 9 and Drupal 10. Found no error in drupal check and upgrade status.
It makes module compatible without error. Attached screenshot for reference.
Moving to RTBC :)
Applied MR changes still found few non ignorable error in drupal check. Created new patch for fixing such deprecated errors. Attached screenshot for reference.
Screenshot attached for reference
Applied MR in Drupal 9.5.7 and D10.0.3 the patch applied successfully and no non ignorable error in drupal check.
No error found in upgrade status.
Found below deprecated warning in upgrade status
jQuery.once() is deprecated in Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the core/once library instead
Added MR changes and my changes in single patch.It makes compatible and there is no non ignorable error in drupal check
Tested Above patch #2 which makes module D10 compatible. No non ignorable error found in drupal check. Found compatiblity status in upgrade status.
Screenshots attached for ref. Moving to RTBC !!
Applied patch#2 which is making module D10 compatible. Also checked the functionality in D9.5.7 and D10.0.3. Hope for latest stable release for D10
Applied patch #5 which is making module D10 compatible. No non ignorable drupal check errors.Attached screenshot for reference.
Moving to RTBC !
Applied patch#2 and that makes module compatible. But found few errors in drupal check. Resolved that in my patch and checked its functionality. Working as expected. No non ignorable error in drupal check.
Applied rector patch which is making module D10 compatible. Checked in drupal 9.5.7 and drupal 10.0.3. No drupal check errors found after patch. Hope for stable d10 release !!
Applied rector patch which makes module D10 compatible. When checking the functionality sitemap generated but url is not displayed in both D9 and D10.
Created Patch for resolving it, and now the url is generated and displayed when we hover on it. Attached screenshot for reference.
Patch applied successfully and no non ignorable errors in drupal check and upgrade status.
Attached screenshot for reference. Moving to RTBC !!
Tested Patch #2 manually. This module has dependency on domain and domain config. So after installing and making thes two modules compatible with D10, we are good to enable domain_site_settings. The functionality is working fine in D9 and D10.
Screenshot attached for reference.
Testing methods:
1. Tried installing domain_site_settings but due to dependencies it is not installed.
2. Installed domain and domain_config module and made it D10 compatible.
3. Now domain_site_settings module is enabled and patch is applied.
4. Checked its functionality by refering
https://www.drupal.org/project/domain_site_settings →
.
5. Checked in drupal check, where the errors are ignorable
Moving to RTBC !
Patch #2 applied successfully and checked in Drupal 9.5.7 . No drupal check errors found and no upgrade status error found.
Functionality is working as expected.
2/2 [============================] 100%
[OK] No errors
Thanks for using drupal-check!
Followed below steps for functional checking:
1. It has dependency which is meta tag module.
2.Install both and enable it.
3.Add new field as metatag to any content type(article/basic)
4. In Manage display set that field as raw.
5. Tried adding new content and added some values to metatag in that.
6. Now we can see added metatag values in page if field is setted as raw.
Moving to RTBC!
Reviewed Patch#2 , it is not applied successfully. Found below error:
git apply --check field_hidden.2.0.0.rector.patch
error: patch failed: field_hidden.info.yml:1
error: field_hidden.info.yml: patch does not apply
Created new patch which is applied successfully.Found no error in drupal check and upgrade status. Functionality is working as expected.
I hope for stable release for D10.
This patch makes module D10 compatible.
Tested patch in Drupal 9 and Drupal 10. Patch is applied successfully and no non ignorable errors in drupal check.
Functionality is working in both D9.5.7 and D10.0.3 with php 8.1. Attached screenshot for reference.
Moving this to RTBC !
Chandra Gowsalya Kannan → created an issue.
Applied Patch#2 , patch not applied successfully. Creating new patch for making D10 compatible and added configure link to save configuration form.
Before and after Screenshot attached for module compatible. Functionality is working as expected. No errors found in drupal check.
php vendor/bin/drupal-check web/modules/contrib/site_settings_path_alias
2/2 [============================] 100%
[OK] No errors
Thanks for using drupal-check!
Tested the patch #6 but found warning when applying patch. So applied it manually and checked the upgrade status.
The module is compatible with D10 now.
git apply --check geophp_d10-3287733-6.patch
warning: geoPHP/tests/tests/20120702Test.php has type 100644, expected 100755
warning: geoPHP/tests/tests/adaptersTest.php has type 100644, expected 100755
warning: geoPHP/tests/tests/aliasesTest.php has type 100644, expected 100755
warning: geoPHP/tests/tests/geosTest.php has type 100644, expected 100755
warning: geoPHP/tests/tests/methodsTest.php has type 100644, expected 100755
warning: geoPHP/tests/tests/placeholdersTest.php has type 100644, expected 100755
warning: geophp.info.yml has type 100644, expected 100755
warning: geophp.module has type 100644, expected 100755
Applied the patch in comment #4 and getting some drupal check deprecated error for which I attached screenshot.
Resolved some error and made the module D10 compatible in my patch. Attached Before Patch and After Patch screenshot.
Followed this steps for checking the functionality
1, add a blocktabs at admin/structure/blocktabs, for example "Blocktabs test"
2, add views tab to "Blocktabs test", add custom block content tab to "Blocktabs test", it support "views tab", "block content tab", "block plugin tab"
3,navigate to admin/structure/block/list/bartik, click the "Place block" button, you could see "Blocktabs: Blocktabs Test", you can use it now.
4,you could use it on panels config page
Tested patch in comment #10. This patch makes the module D10 compatible.
The functionality is working good in Drupal 9 and Drupal 10. Attached Upgrade status screenshot.
The rest of errors in drupal check are ignorable. Moving to RTBC !!
Chandra Gowsalya Kannan → created an issue.
Applied patch #2 which makes the module D10 compatible. Attached upgrade status screenshot. Before applying the patch, needs to install all dependency modules mentioned in info.yml, then applying patch is working good.
Moving to RTBC !!
Applied the bot patch and tested in Drupal 9.5.7 and D 10.0.3. The functionality is working as expected. Attached screenshot. And there is no drupal check errors.
1/1 [============================] 100%
[OK] No errors
Applied patch #2 and checked its functionality, Got some drupal check errors and when setting configuration got website error, which shows it has dependent on redirect. I have created new patch for resolving website error and drupal check error.
Tested its functionality in Drupal 10.0.3 and drupal 9.5.7 Refer ss for information
Applied patch #7 and tested in Drupal 9.5.7 and D 10 . The functionality is working as expected , attached screenshot for reference. Got some deprecated errors related to Call to Undefined method etc. Resolved that issue in my patch and tested.
Rest of the issue are ignorable for which attached in screenshot.
Tested Patch #2 which works good and make D10 compatibility. But found some drupal check errors which i attached for reference.
I have resolved that drupal check errors in my patch and tested in Drupal 9.5.7 and Drupal 10
Updated the patch for resolving drupal check errors and making module D10 compatible in single patch.
It is working fine for me. Review it and confirm
Created patch for resolving drush_set_error() deprecated code and drush_log() function.
It is solving that drupal check error. Also attached screenshot for which drupal check error are ignorable.
I have applied patch #9 and tested in local D9.5.7 , it makes the module D10 compatible, solving deprecated error and the functionality is working as expected.
Attached screenshot for reference.
Applied patch #3 which is making module D10 compatible and it is solving all drupal check errors.
Checked in D9.5 and D10 Php 8.1
Refer attached screenshot for functionality check
Moving to RTBC :)
The patch #2 is already merged in branch 8.x-1.x. It is making the module to install but when checking in upgrade status , it is not compatible with D10.
Hence created new patch which make the module D10 compatible.
Attached screenshots before and after patch.
Also got some drupal check errors which is ignorable.
Kindly review it and move to RTBC
Applied patch #3 , it is working good and the module made compatible to D10 after verifying in upgrade-status.
Drupal check errors are ignorable for which attached the json in text format.
Not got false ignorable error in drupal check.
Checked in D9.5 and D10 with php8.1
Moving it to RTBC
Tested patch #12 and it is works fine. That patch makes the module D10 compatible and Drupal check errors are ignorable which I attached here.
The patch 2 works fine but with some drupal check error which might not ignorable . I resolved that in my patch.
Applying this will not reproduce drupal check error.
Attaching interdiff between #2 and my patch. Functionality is working as expected
Applied #8 Patch which makes this module D10 compatible . Attached upgrade status screenshot.
Also attached Drupal check warnings which are ignorable.
Checked the functionality which is changing [path-to-theme] to active theme path.
TESTING METHOD:
1.Download theme_filter module and enable it
2. If it is not able to install, apply the #8 patch then we can install
3. Download theme and enable “Replace theme tokens” in admin/config/content/formats
4. Make downloaded theme as default then add content > and select particular text format for which filter is enabled
5. paste in body part and save
6. Respective theme image will be shown.
This rector patch is working fine in D9 and D10.
Before applying the patch, this module is not able to be installed.
This patch looking good for me and there is no drupal-check error
Refer the attached screenshot for functionality and D10 compatability check
$ php vendor/bin/drupal-check web/modules/contrib/ckeditor_bootstrap_grid
2/2 [============================] 100%
[OK] No errors
Thanks for using drupal-check!
Consider sponsoring the development of the maintainers which make drupal-check possible:
- phpstan (ondrejmirtes): https://github.com/sponsors/ondrejmirtes
- phpstan-deprecation-rules (ondrejmirtes)): https://github.com/sponsors/ondrejmirtes
- phpstan-drupal (mglaman)): https://github.com/sponsors/mglaman
- drupal-check (mglaman)): https://github.com/sponsors/mglaman
Applied the project update bot patch and tested in Drupal 9 and Drupal 10.
In D9 , patch is working without any site functionality breakage and shown D10 ready in upgrade-status.
In D10, Fixed below issue in my patch and checked the functionality which is working as expected. Refer screenshot for D10 Functionality
Got some common Drupal check warnings in D9 and D10 which are ignorable when checking in json format.
--------------------------------------------------------------------------------
78 Relying on entity queries to check access by default is deprecated in
drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call
\Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or
FALSE to specify whether access should be checked.