- Issue created by @rahul1707
- Assigned to rahul1707
- Status changed to Needs work
over 1 year ago 6:32am 5 May 2023 - Status changed to Needs review
over 1 year ago 7:56am 5 May 2023 - ๐ฎ๐ณIndia rahul1707
Created patch to makes this module D10 compatible and resolve below issue :
The website encountered an unexpected error. Please try again later.
Error: Class "Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget" not found in include() (line 24 of modules\contrib\linked_entity_reference\src\Plugin\Field\FieldWidget\LinkedMediaLibrary.php).Kindly review it.
- Status changed to RTBC
over 1 year ago 6:25am 8 May 2023 - ๐ฎ๐ณIndia Chandra Gowsalya Kannan
Tested patch in Drupal 9 and Drupal 10. Patch is applied successfully and no non ignorable errors in drupal check.
Functionality is working in both D9.5.7 and D10.0.3 with php 8.1. Attached screenshot for reference.Moving this to RTBC !
- ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
Eduardo Morales Alberti โ made their first commit to this issueโs fork.
- ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
We need to update this module to be compatible with drupal 10, the problem is, that until is not merged, we should use a fork because the patch with the compatibility applies after composer resolves the dependencies.
We will open a fork, to be able to use this module on drupal 10 until the patch is merged. - Merge request !2Resolve #3358368 "Drupal 10 compatibility" โ (Merged) created by eduardo morales alberti
- ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
Using drupal upgrade status we got the following message after the analysis:
Class Drupal\linked_entity_reference\Plugin\Field\FieldWidget\LinkedMediaLibrary extends @internal class Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget.
- ๐ช๐ธSpain eduardo morales alberti Spain, ๐ช๐บ
Maybe the core classes should not be internal https://www.drupal.org/project/drowl_layouts/issues/3350603 ๐ Discuss how to fix extending an internal Drupal core base class Postponed
We think this is an error that can be ignored by now. - Issue was unassigned.
- ๐ช๐ธSpain tunic Madrid
Reviewed, module installs properly and seems to work.
Detected ๐ "There are no content items matching" when trying to add a second value in a multivalued field Active but this bug is present prior to this update, so not blocking for this.
-
tunic โ
committed e43bd860 on 1.0.x authored by
Eduardo Morales Alberti โ
Resolve #3358368 "Drupal 10 compatibility"
-
tunic โ
committed e43bd860 on 1.0.x authored by
Eduardo Morales Alberti โ
- Status changed to Fixed
11 months ago 2:50pm 28 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.