Contrib.social

Discuss how to fix extending an internal Drupal core base class

Open on Drupal.org →
Created on 27 March 2023, over 1 year ago
Updated 9 May 2024, 7 months ago

Postponed on ✨ Make MultiWidthLayoutBase non-internal Active

Problem/Motivation

We are currently extending an internal "layout_builder" base class:

Class Drupal\drowl_layouts\Plugin\Layout\DrowlLayoutsMultiWidthLayoutBase extends @internal class Drupal\layout_builder\Plugin\Layout\MultiWidthLayoutBase.

FYI:

The @internal tag is used to denote that associated Structural Elements are elements internal to this application or library.

Should we create a core issue and ask why this Base Class is set as internal? Let's discuss.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Grevil
  • Status changed to Postponed over 1 year ago
  • Comment over 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    Thanks @Grevil I agree we should suggest to make the base class non-internal in core. It's very helpful and would be better to not have it market @internal.

    Until that's solved I hope there are no issues with this method besides the warning.

    Postponed on ✨ Make MultiWidthLayoutBase non-internal Active

  • Assigned to Grevil
  • Status changed to Active 7 months ago
  • Comment 7 months ago →
    🇩🇪Germany Anybody Porta Westfalica

    The core issue is now fixed, so that we should be able to solve this here and in drowl_layouts_bs?

  • Issue was unassigned.
  • Status changed to Fixed 7 months ago
  • Comment 7 months ago →
    🇩🇪Germany Grevil

    Nothing to solve here! "DrowlLayoutsMultiWidthLayoutBase" still extends "MultiWidthLayoutBase", but since "MultiWidthLayoutBase" isn't internal anymore, we now do not get a warning anymore! :)

    Fixed through ✨ Make MultiWidthLayoutBase non-internal Active !

  • Comment 7 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024