- 🇮🇳India Chandra Gowsalya Kannan
Tested Patch #2 manually. This module has dependency on domain and domain config. So after installing and making thes two modules compatible with D10, we are good to enable domain_site_settings. The functionality is working fine in D9 and D10.
Screenshot attached for reference.Testing methods:
1. Tried installing domain_site_settings but due to dependencies it is not installed.
2. Installed domain and domain_config module and made it D10 compatible.
3. Now domain_site_settings module is enabled and patch is applied.
4. Checked its functionality by refering https://www.drupal.org/project/domain_site_settings → .
5. Checked in drupal check, where the errors are ignorable
Moving to RTBC ! - last update
over 1 year ago Composer require failure - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - last update
over 1 year ago Patch Failed to Apply - Status changed to RTBC
over 1 year ago 12:13pm 21 July 2023 - 🇸🇰Slovakia kaszarobert
We were getting this when trying to install this module with the latest domain v2.0:
Your requirements could not be resolved to an installable set of packages. Problem 1 - Root composer.json requires drupal/domain_site_settings ^1.4 -> satisfiable by drupal/domain_site_settings[1.4.0, 1.x-dev]. - drupal/domain_site_settings[1.4.0, ..., 1.x-dev] require drupal/domain ^1.0 -> found drupal/domain[1.0.0-beta1, ..., 1.0.0-beta8] but it conflicts with your root composer.json require (^2.0@beta). Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions. You can also try re-running composer require with an explicit version constraint, e.g. "composer require drupal/domain_site_settings:*" to figure out if any version is installable, or "composer require drupal/domain_site_settings:^2.1" if you know which you need. Installation failed, reverting ./composer.json and ./composer.lock to their original content.
The patch #2 fixed this issue, patch #6 and #7 could not be applied. So RTBC for patch #2.
Also, we have to use the module as the new way this could be achieved in Domain module could break the site config as 🐛 Using Domain Config UI creates *.yml files with duplicate UUIDs. Needs work .
- last update
over 1 year ago 2 pass - 🇺🇸United States johne
I re-rolled this patch and it now applies to the latest in dev. However it looks like composer.lock is generated before patches are applied. So, composer.lock will not correctly list changes to the require section of this module. I had to manually edit composer.lock to be able to install 2.x of domain.
- First commit to issue fork.
- last update
over 1 year ago 2 pass - @johne opened merge request.
- 🇺🇸United States johne
Ah, the correct way around this is to use an issue fork that already has the needed changes.
- 🇧🇬Bulgaria rumendamyanov Plovdiv, Bulgaria (EU)
@johne Thanks for the warning about 'composer.lock' and the provided fork with the needed changes.
- Status changed to Fixed
about 1 year ago 6:38am 23 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.