Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 12 April 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot → .
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task
Status

RTBC

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇮🇳India abhinavk

    I tested patch #2 and got below errors in drupal-check. Autocomplete gives error while checking in local, in local dblog, due these drupal-check errors. So I have fixed them.

    $ drupal-check ckeditor_link_with_text
    3/3 [============================] 100%

    ------ ---------------------------------------------------------------------------------------------------------------
    Line src\Controller\AutocompleteController.php
    ------ ---------------------------------------------------------------------------------------------------------------
    30 Property Drupal\ckeditor_link_with_text\Controller\AutocompleteController::$entityQuery has unknown class
    Drupal\Core\Entity\Query\QueryFactory as its type.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    37 Property Drupal\ckeditor_link_with_text\Controller\AutocompleteController::$aliasManager has unknown class
    Drupal\Core\Path\AliasManager as its type.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    47 PHPDoc tag @param for parameter $aliasManager with type Drupal\Core\Path\AliasManagerInterface is not subtype
    of native type Drupal\Core\Path\AliasManager.
    47 Parameter $aliasManager of method
    Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
    Drupal\Core\Path\AliasManager.
    47 Parameter $aliasManager of method
    Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
    Drupal\Core\Path\AliasManagerInterface.
    47 Parameter $entityQuery of method
    Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
    Drupal\Core\Entity\Query\QueryFactory.
    47 Parameter $entityQuery of method
    Drupal\ckeditor_link_with_text\Controller\AutocompleteController::__construct() has invalid type
    Drupal\Core\Entity\Query\QueryFactory.
    79 Call to method get() on an unknown class Drupal\Core\Entity\Query\QueryFactory.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    81 Function db_like not found.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    83 Function entity_load_multiple not found.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    85 Call to method getAliasByPath() on an unknown class Drupal\Core\Path\AliasManager.
    💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
    ------ ---------------------------------------------------------------------------------------------------------------

    ------ ---------------------------------------------------------------
    Line src\Form\LinkTextEditorDialog.php
    ------ ---------------------------------------------------------------
    43 PHPDoc tag @param references unknown parameter: $file_storage
    ------ ---------------------------------------------------------------

    [ERROR] Found 12 errors

  • Status changed to RTBC over 1 year ago
  • Comment over 1 year ago →
    🇮🇳India Chandra Gowsalya Kannan

    Applied patch #3 which is making module D10 compatible and it is solving all drupal check errors.
    Checked in D9.5 and D10 Php 8.1
    Refer attached screenshot for functionality check
    Moving to RTBC :)

  • First commit to issue fork.
  • Merge request !1Drupal 10 Comaptible → (Closed) created by tushar1
  • Comment 12 months ago →
    System Message
  • Comment 12 months ago →
    tushar1

    Tushar1 → changed the visibility of the branch 3296763-automated-drupal-10 to hidden.

  • Merge request !2Drupal 1o Compatible Fixes → (Open) created by tushar1
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024