Automated Drupal 10 compatibility fixes

Applied the merge request in Drupal 9 and Drupal 10. Found no error in drupal check and upgrade status.
It makes module compatible without error. Attached screenshot for reference.

Moving to RTBC :)

After the changes in this last commit, the configuration page seems to be broken.
Errors like the one below seem to point at this commit.

TypeError: Drupal\popup_message\Form\PopupMessageSettingsForm::__construct(): Argument #1 ($cssOptimizer) must be of type Drupal\Core\Asset\CssCollectionOptimizerLazy, Drupal\Core\Asset\CssCollectionOptimizer given, called in /var/www/html/web/modules/contrib/popup_message/src/Form/PopupMessageSettingsForm.php on line 81 in Drupal\popup_message\Form\PopupMessageSettingsForm->__construct() (line 66 of modules/contrib/popup_message/src/Form/PopupMessageSettingsForm.php).

Hi LRoels , thank you for reporting this issue. It's been fixed. Release 2.0.2 contains this change.

I currently upgraded to the 2.0.2 release, cleared the cache, and I am getting the error marked in comment #14 when I go to the configuration page for the module. This is curious, because I am confirming that I am seeing CssCollectionOptimizerLazy name changes in the code in our codebase to confirm we pulled in the latest changes. Not sure, but wanted to drop in a comment that I am also having an issue. I will check to see if I have made an oversight somewhere.

Hi, we also still get the error after updating to the 2.0.2 release.
I think it has to do with the lazy class not existing untill 10.1 ( https://www.drupal.org/node/2888767 → ).
We are using D10.0.9. It seems best to keep using the CssCollectionOptimizer class because otherwise the module is not backwards compatible.

Confirm - 2.0.2 is broken with 9.5.9 Drupal Core

First time patch maker :) - I have tentatively put a patch together that I think should work for folks who want to upgrade to 2.0.2 but are still on D9 or it seems prior to D10.1 according to LRoels and the docs linked to. It mainly takes off the "Lazy" parts in PopupMessageSettingsForm.php. I have tested applying it to my D9 project and now the configuration menu works well. To be clear, this patch should not be merged in, but a helpful bridge to help people upgrade the module but have it work on D9 prior to the D10 jump.

Feel free to improve upon it and make it your own.

Version 2.0.3 released as compatible with Drupal 8 || 9. Drupal 10 compatibility released as 3.0.0 version.

I'm wondering why can't we make the v3 compatible with D9?

How do I upgrade from Drupal 9 to Drupal 10 if I have this module on v2?

Hi Carolpettirossi,

we had to split versions due to breaking changes. CssCollectionOptimizer starting from Drupal 10.1 is deprecated in favor of CssCollectionOptimizerLazy and CssCollectionOptimizerLazy is not available for Drupal 9.

When it comes to upgrade Drupal 9 to 10 you need to update module's version i composer.json or just run composer require drupal/popup_message after upgrade Drupal 9 to Drupal 10.

Hi Carolpettirossi,

You can use "drupal/popup_message":^2.0 || ^3.0 in composer.json while upgrading from D9 to D10. So, that we won't be getting any blockers.

Thanks for the suggestion =)

I think with the release 3.0.0, there is now a stable Drupal 10 release. In addition to sakthi_dev's comment about how to upgrade from D9 to D10 with some simple composer syntax to either use 2.x or 3.x, this ticket can be closed now and have the status marked as "fixed"? I am not sure if a maintainer should do that or if it's deemed permissible for someone else to do?