@spuky or anyone else, once the merge requests get merged in, do those diff files disappear as URLs? I am trying to get a 10.3 release going for our site and do not want to reference URLs that will eventually disappear, breaking our applying of patches. Thank you!
Coming in a few years after the fact, but wanted to share how our project did it simply. We had a project that used this module. It was seemingly straight forward to "hand migrate" the configuration settings to Domain Config, using the Domain Config UI. We had about 6 domains for reference. If anyone else is looking for an upgrade path, I might recommend that.
- Copy and paste the Domain Site Settings configuration from domain_site_settings.domainconfigsettings.yml into a notes application for reference
- Uninstall Domain Site Settings module
- Install the Domain Config UI module (Domain Config was already installed)
- Go to /admin/config/system/site-information
- Select the domain that you want to configure
- Go back to your configuration settings that you pasted into your notes
- Fill out the requisite values for the site name, front page, 404 page etc
- Save!
- Repeat those configuration steps in the Site Information page for each domain until you are done.
- That should be it from what I can tell.
There are a few other steps about removing the module from composer that are part of the normal Drupal workflow, but wanted to share how we upgraded from this module to Domain Config without a need for automation.
After reading through the comments and having had the community respond -- this seems like an issue present elsewhere rather than the Password Policy module itself. I'll close the issue for now and mark it as "Closed works as designed". Thank you for the input and solutions all around!
I think with the release 3.0.0, there is now a stable Drupal 10 release. In addition to sakthi_dev's comment about how to upgrade from D9 to D10 with some simple composer syntax to either use 2.x or 3.x, this ticket can be closed now and have the status marked as "fixed"? I am not sure if a maintainer should do that or if it's deemed permissible for someone else to do?
Ah, thank you for the quick clarification :)
For this module, is there testing required on this front or is it just a matter of creating the release? We are looking to update this module for our D10 push on a project. Thanks!
+1 to carolpettirossi's comment! This is one of our modules we are looking to upgrade for our D10 push on a project of ours. Do we need testing on this? Or, is this just a matter of creating a release?
Great, thank you for the prompt reply and work on everything!
Thank you for the clarification - quick question - is there an order of operations issue to look out for? If we have already upgraded the Metatag module but have not removed Metatag Routes module yet, are there any concerns or gotchas when we remove the Metatag Routes module? Now, that I saying it out loud, we haven't had any with both operating, but it's worth asking and for visibility for anyone else. Thanks!
First time patch maker :) - I have tentatively put a patch together that I think should work for folks who want to upgrade to 2.0.2 but are still on D9 or it seems prior to D10.1 according to LRoels and the docs linked to. It mainly takes off the "Lazy" parts in PopupMessageSettingsForm.php. I have tested applying it to my D9 project and now the configuration menu works well. To be clear, this patch should not be merged in, but a helpful bridge to help people upgrade the module but have it work on D9 prior to the D10 jump.
Feel free to improve upon it and make it your own.
I currently upgraded to the 2.0.2 release, cleared the cache, and I am getting the error marked in comment #14 when I go to the configuration page for the module. This is curious, because I am confirming that I am seeing CssCollectionOptimizerLazy name changes in the code in our codebase to confirm we pulled in the latest changes. Not sure, but wanted to drop in a comment that I am also having an issue. I will check to see if I have made an oversight somewhere.
Agreed with Heddn and others, looking for a Drupal 10 compatible tag as it seems it's been tested! Thank you :)
Last week, I attempted to apply either patch (#2 and #10) to the develop branch of the Login Security module. Unfortunately, both failed. I am curious if others are having a similar issue? We are using the Mail Login module. When we uninstall the Mail Login module, the Login Security module works perfectly!
I will add support for making a D10 release -- we are doing our upgrade and it appears folks have tested this above in the thread.