Automated Drupal 10 compatibility fixes

Can we move forward with a D10 release now it's RTBC?

Chiming in that this looks good. Just the core_version_requirement change was made here. I've tested both against Drupal 9.5.4 and 10.0.4.

I opened a merge request to make it easier to close this out hopefully.

The other relevant news is that admin_toolbar now has a tagged release with Drupal 10 compatibility, so can very easily and naturally follow at any time.

I have verified the D10 compatibility changes and they are working correctly. We can proceed with the release.

I tested the patch on D10 and it works as expected,
upgrade status scan clear as well

Thanks a lot Ted for approving the merge request.

All the changes in this ticket have now been successfully committed to the 8.x-1.x dev branch.

The module's dev head is now compatible with D10, thus marking this issue as Fixed for now.

Feel free to let us know if you encounter any issues while testing or have any questions or concerns on any of the changes in this ticket or the module in general, we would surely be glad to help.
Thanks in advance!

Thanks @DYdave!

Any plans for a new release for the D10 compatibilty?

Do we have an update on this?

Great, ty for getting the dev version d10 ready. What is the timeline (or blockers) for merging this to production?

Automatically closed - issue fixed for 2 weeks with no activity.

Please create a Drupal 10 compatible tag of the project so the project page will say it supports Drupal 10. :pray:

Agreed with Heddn and others, looking for a Drupal 10 compatible tag as it seems it's been tested! Thank you :)

The adminimal theme has a D10 compatible release since 08/08/'23, time for a stable release of the toolbar I'd say ;)

Ok

When do you plan to release a new version for D10 compatibility?
For now I am using the dev version. Thank you!

Hi guys,

We recently got a new release for the Adminimal theme project, making it compatible with D10.

It would be awesome to see a release for this module as well, since they are obviously used together.

Talking from a client perspective, as we are recently dealing with many D10 upgrades, it's good to be able to maintain the same UI/UX of the toolbar when navigation through the admin section and also on content pages of the site, which is not possible if this module is not installed. And this is the case now for many sites upgrading to D10.

This is a very simple fix, so let's get this into a release!

Cheers.

A new release would be awesome. This kinda blocks me from updating easily to D10.

Another reminder to please create a Drupal 10 compatible release. I am on the verge of removing this module from a dozen sites, which I'd prefer not to do.

if you prefer not to use the dev version, you can specify this issue's fork as the repository and pull in the patched module that way

composer.json

add to the "repositories" section:

  "repositories": {
        "adminimal-admin-toolbar": {
            "type": "package",
            "package": {
                "name": "drupal/adminimal_admin_toolbar",
                "type": "drupal-module",
                "version": "dev-3285987-automated-drupal-10",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/issue/adminimal_admin_toolbar-3285987.git",
                    "reference": "3285987-automated-drupal-10"
                }
            }
        },
    }

... then update in the "require" section:

        "drupal/adminimal_admin_toolbar": "dev-3285987-automated-drupal-10",

Hi guys, I understand there is a dev version, but it is not a great practice to use dev version on production. Would it be possible to please release D10 compatible version so we can take advantage of composer automation? If there is anything low-code drupalist can do, please let me know! From the comments here it seems, nothing is standing in the way :).

Same in #32

composer.json:

"repositories": [
        {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/adminimal_admin_toolbar-3285987.git"
        },
]

then update in the "require" section:

"drupal/adminimal_admin_toolbar": "dev-3285987-automated-drupal-10"

You can also install patches using cweagans/composer-patches

e.g.

        "patches": {
            "drupal/adminimal_admin_toolbar": {
                "Automated Drupal 10 compatibility fixes - https://www.drupal.org/project/adminimal_admin_toolbar/issues/3285987": "https://www.drupal.org/files/issues/2022-06-15/adminimal_admin_toolbar.1.x-dev.rector.patch"
            }
        },

I wholly agree with all requests for a D10 release. This is update blocking for many of us.

Hello @energee

Thanks for your module. It's really useful. I wonder if you need help for tagging a new release (because a lack of time I suppose) ? If it's the case I can happily do it for you (I just need the right access to the repository).

Hi ! +1 for tagged release, thanks !

If you need to upgrade to Drupal 10, don't repositories but patches and lenient

Here's the official doc

https://www.drupal.org/docs/develop/using-composer/using-drupals-lenient... →