🇫🇷France @Renrhaf

Same issue here, store in 4 languages and invoices translation has some issues

+1

+1

Fixed, thanks

Thanks for the bug report & sorry for breaking your integration.
We'll take a look at this soon !

Oh sorry I did not see that your last comment was in 2021 ! Fair enough, we'll see, thanks !

Hi @xavier.masson, is this still relevant to you ?
or to anyone else ?

Merged, thank you all !
I've noticed that on my Drupal 11 test install, the manually defined thumbnail was erased by the automatic one when creating a new media.
I've decided to merge the patch as it is for now as it already brings a most wanted feature.

@Jaypan : on comment #14 you said you were able to have a manual thumbnail on media creation ?

Fixed, thanks !

merged, thanks !

renrhaf → made their first commit to this issue’s fork.

Merged, thanks !

renrhaf → made their first commit to this issue’s fork.

Merged, thank you all!

renrhaf → made their first commit to this issue’s fork.

Fixed, thanks

This issue is not more relevant after https://www.drupal.org/project/media_thumbnails/issues/3469479 📌 Fix phpstan issue Fixed was fixed with Drupal 11 compatibility fixes as well.

ConfigFactoryInterface's get method always returns an ImmutableConfig instance :

interface ConfigFactoryInterface {

  /**
   * Returns an immutable configuration object for a given name.
   *
   * @param string $name
   *   The name of the configuration object to construct.
   *
   * @return \Drupal\Core\Config\ImmutableConfig
   *   A configuration object.
   */
  public function get($name);
...

Closing it, thanks !

Thanks for the patch, I've adapted it for Drupal 11.
It will be published in the next release after some more testing.

Thanks for the report, indeed the ContainerAwareInterface has to be removed for the Drupal 11 support.
I'm going to take this ahead and test it for merging.

Thanks all for the report, investigation and fix.
I've committed directly from my console but I've credited all of you on the commit.
I will publish a release with these fixes.

+1 thanks for the patch, working for us

I'm still having the issue with the 8.0.x-dev version :
400 Bad Request: {"error":{"root_cause":[{"type":"parsing_exception","reason":"Expected [START_OBJECT] under [filter], but got a [START_ARRAY] in [product_language_filtered]","line":1,"col":542}],"type":"parsing_exception","reason":"Expected [START_OBJECT] under [filter], but got a [START_ARRAY] in [product_language_filtered]","line":1,"col":542},"status":400}

See xDebug of the variable when the problem occurs : https://ibb.co/891yjXR

MR submitted, we are using the patch in production already.

renrhaf → created an issue.

Hi there, coming from here https://github.com/dunglas/frankenphp-drupal/issues/1#issuecomment-23439... just to say that we are using FrankenPHP on a few Drupal projects in production for a few months now. We had some issues related to BigPipe as FrankenPHP has a known issue with PHP Fibers, but appart from that things are running smoothly. We can not use the worker mode yet as the Symfony Runtime is not supported by Drupal as of now.

FrankenPHP got some good performance boosts this summer so the performance tests that were done might be giving different results now.
I'm not sure how to help here to make things go forward.

Fixed in 2.x version, thank you all !

Should be fixed, but on the 2.x branch, upgrade if needed, thanks !

Fixed, thanks !

Patch committed to 2.x branch, thanks !

+1 that fixes the saturated color issues for us as well ! thanks @kosa-ilma !

Hi @anybody, the transactional email sending feature was the first main milestone of the module.

If you don't want to send transactional emails, enabling the module will not force you to. You still have to configure MailSystem/Symfony mailer to do so. I understand your idea of separating features into submodules, and I'll look into it when I'll implement some more features.

Hi Sokru, thanks for the review I'll give it a try asap and report back

Setting to reviewed & tested since multiple people have confirmed this patch works for them for many years (me included).

Rerolled patch for 1.8 version of the module.

Adding a patch compatible with the 1.8 version of the module, deprecating watchdog_exception when possible.

Thanks Chris !
I've use the first logo you proposed, I just had to generate a new one in PNG from the Brevo press kit (https://www.brevo.com/fr/press-room/)

Hi there, Brevo has agreed for small sponsoring of the module to provide as a starting point the transactional email API feature.
So we can consider this module as the "official" Brevo one, since they might want to keep it up to date as well and provide some more sponsoring for additional features. We, at SaaS Production, will also sponsor some time of development for this module to implement some missing features for some of our clients.

On the roadmap of future features, we can already foresee the two following things :

• Newsletter subscription forms
• Drupal commerce integration (pushing events to Brevo when users are adding products to cart, ordering, etc.)

Don't hesitate to share feedback and missing features that you would need.
Thanks!

We just published the first release for the official Brevo module → . At the moment, the only feature supported is sending the transactional emails via Brevo's API. You can give it a try and provide feedback in the issue queue if you encounter any problem or if something is not clear/missing. Thanks!

Future releases of this module might implement newsletter subscription feature.
We will try to make it as user friendly as we can, to provide basic feature out of the box, and also as developer friendly as possible for overriding. Thanks.

Future releases of the module might implement some new features like newsletter subscription.
Can you describe more in details, or with some capture, what is the expected behavior and where the checkbox should be located exactly ?
Thanks !

I've pushed a first release for the brevo module which includes support for both Mailsystem & Symfony Mailer.
When Symfony Mailer is installed, a transport will be automatically managed for Brevo based on the Symfony Brevo bride (https://github.com/symfony/brevo-mailer). When Mailsystem is installed, a new plugin is here to tackle the email sending feature through Brevo's API. You can give it a try and give me feedback if anything needs some adjustments. Thanks !

Same here, I have some issues having this plugin to work.
To investigate you need to check the logs as the UPSRateRequest is logging any error when calculating the rates.
For me it was "UPS Access Point Economy Service shipments must have a Hold for Pickup at UPS Access Point or UPS Access Point Delivery" so I disabled the "UPS Access Point Economy" shipping service.

Renrhaf → created an issue.

Renrhaf → created an issue. See original summary → .

Thank you @energee !

Hi there, I'm also able to opt into security advisory policy, and willing to give a little bit of my time to update this projet.
I'm sad to see that I might have to remove it from all our projects if it does not get a proper update for Drupal 10 :(

Hi Rajan Kumar, patch tested, it fixed the issue. Thanks !

Hi himanshu_jhaloya,

There is an issue with your patch :

Warning: Undefined variable $timestamp_single_day_event in extra_body_classes_preprocess_html() (line 112 of modules/contrib/extra_body_classes/extra_body_classes.module).

Otherwise the original issue is fixed

patch #5 working, thanks

+1 it would allow to use worker mode to boost performances considerably

Would be an awesome feature !

+1 for merging and creating tagged release for D10 ! thanks :)

+1 for tagged release for D10 ! thanks :)

FrankenPHP official support in Drupal would be awesome, I'll give it a try if I find the time !

+1
Patch is needed for D10 upgrade

+1 RTBC

Hi ! +1 for tagged release, thanks !

+1

+1 RTBC

+ ./local-php-security-checker
Symfony Security Check Report
=============================
1 package has known vulnerabilities.
firebase/php-jwt (v5.5.1)
-------------------------
 * [CVE-2021-46743][]: Key/algorithm type confusion
[CVE-2021-46743]: ]8;;https://github.com/advisories/GHSA-8xf4-w7qw-pjjwhttps://github.com/advisories/GHSA-8xf4-w7qw-pjjw]8;;
Note that this checker can only detect vulnerabilities that are referenced in the security advisories database.
Execute this command regularly to check the newly discovered vulnerabilities

There is a security issue with the currently used library

Rerolled #45 for latest smart trim branch 2.0.x

Patch was commited into 7.0.0-alpha4 release :)

I had to revert the update because of some issues with this patch with the new version. Will try again later and update my comment.

Rerolled #12 for version 2.0.8

Sorry for the mess...
Merge request https://git.drupalcode.org/project/facets/-/merge_requests/121 should be used.
https://git.drupalcode.org/project/facets/-/merge_requests/121.patch for those who wants to patch it in the meantime

Rerolled patch from #28 for version 2.0.6.
I did not include any changes from #33, #34, #35 as it seemed to be related to some other bug and not relevant here.
Thank you.

Also faced this issue, fixed using the command line :
./vendor/bin/drush php:eval "\Drupal::keyValue('update_fetch_task')->deleteAll();"