- Issue created by @Andrii Momotov
- Merge request !4Issue #3468528: Fix the warning reported by PHP_CodeSniffer → (Merged) created by Andrii Momotov
- Status changed to Needs review
3 months ago 11:59am 16 August 2024 - 🇺🇦Ukraine Andrii Momotov
Fixed the warning reported by PHP_CodeSniffer and created MR. Please review. Thanks!
- Issue was unassigned.
- 🇺🇦Ukraine Andrii Momotov
Fixed the warning reported by PHP_CodeSniffer and created MR. Please review. Thanks!
- Assigned to paraderojether
- Status changed to Needs work
3 months ago 5:00am 20 August 2024 - 🇵🇭Philippines paraderojether
Hi
I reviewed MR!4, applied against Media Thumbnails 8.x-1.x-dev and there is one phpcs error shown below:
✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig media_thumbnails FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/media_thumbnails/src/Plugin/MediaThumbnailManager.php --------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface. --------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------------- Time: 350ms; Memory: 10MBThank you.
- Issue was unassigned.
- Status changed to Needs review
3 months ago 5:18am 20 August 2024 - 🇵🇭Philippines paraderojether
I fixed the remaining issue, please review.
Thank you.
- Status changed to RTBC
3 months ago 7:00am 20 August 2024 - 🇮🇳India riddhi.addweb
The mentioned issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.
- First commit to issue fork.
-
renrhaf →
committed 656f1eb8 on 8.x-1.x authored by
andrii momotov →
Issue #3468528: Fix the warning reported by PHP_CodeSniffer
-
renrhaf →
committed 656f1eb8 on 8.x-1.x authored by
andrii momotov →
- Status changed to Fixed
2 months ago 5:27pm 15 September 2024 -
renrhaf →
committed 656f1eb8 on media_thumbnails-3468533-3468533-set-up-gitlab authored by
andrii momotov →
Issue #3468528: Fix the warning reported by PHP_CodeSniffer
-
renrhaf →
committed 656f1eb8 on media_thumbnails-3468533-3468533-set-up-gitlab authored by
andrii momotov →
Automatically closed - issue fixed for 2 weeks with no activity.