Replaced direct database query in bulk_update_fields_entity_operation_alter() with \Drupal::configFactory()->listAll().
Please review MR. Thanks!
I assigned the task to myself because I plan to work on this issue.
Please do not work on this issue.
Andrii Momotov → created an issue. See original summary → .
I reviewed and tested the patch https://www.drupal.org/files/issues/2023-04-16/bulk_update_fields-add-sc... → created by @hkirsman, and it is correctly done and works well. Therefore, I created a Merge Request based on this patch. Please review. Thanks!
Added a composer.json file and included all the required information. Please review MR. Thanks!
Set up GitLab CI. Please review MR. Thanks!
Fixed Typo: In word 'exlude'. Please review my MR:
https://git.drupalcode.org/project/bulk_update_fields/-/merge_requests/13
Thanks!
@deepak5423 You acted very unfairly! This is not acceptable in our Drupal community!
You saw:
1. That I assigned this issue to myself.
2. I wrote a comment stating that I planned to work on this issue.
Nevertheless, you still went ahead and started working on it.
Fixed the errors/warnings reported by PHP_CodeSniffer and created MR. Please review. Thanks!
I assigned the task to myself because I plan to create a composer.json file, describe it, and make a Merge Request.
Andrii Momotov → created an issue.
I assigned the task to myself because I plan Set up GitLab CI and make a Merge Request.
Andrii Momotov → created an issue.
I assigned the task to myself because I plan to fix this typo and make a Merge Request.
Andrii Momotov → created an issue.
I assigned the task to myself because I plan to fix phpcs errors and make a Merge Request.
Andrii Momotov → created an issue.
I assigned the task to myself because I plan to make a Merge Request for this issue.
Hi Jether,
Thank you for the review!
Reviewed and tested in the testing environment. Merged.
Thank you!
Hi Rob,
Thank you for your review and reply!
Hi Kevin,
Thank you very much! I'll be glad to assist you in supporting and improving this module!
Hi Luciano,
I checked on my end and it looks good.
Thanks!
Hi Luciano,
I have tested it in a testing environment and everything is ok.
Thank you!
Andrii Momotov → created an issue.
Hi Luciano,
I would like to clarify. Are you asking me to test it when it's in the new release, or are you asking to test it on the 4.0.x branch right now?
Thank you!
Hi Luciano,
Just a friendly reminder about this issue.
Thank you!
Hi Luciano,
In our case, it's not required to add a composer.json file to the module, it's according to your wishes. Here are several scenarios where it is required:
https://www.drupal.org/docs/develop/using-composer/add-a-composerjson-file →
But if in the future you decide to extend the module in any way, you won't need to create this file because it will already exist :)
In addition, adding this file opens up several possibilities that are described in the article linked above.
Don't worry, the presence of this file will not affect the functionality of the module in any way.
Thanks!
Hi Luciano,
Thank you for reviewing MR! I tested and everything works as well as before the changes.
@Nupur Badola Thank you for the report!
Changed the code of README.md according to the instruction:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
@Nupur Badola Thank you for the report!
Changed the code of README.md according to the instruction:
https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
Added composer.json file. Please review. Thanks!
Andrii Momotov → created an issue.
Fixed the errors/warnings reported by PHP_CodeSniffer.
Please review. Thanks!
Andrii Momotov → created an issue.
Сreated a README.md file with a description of the module's functionality and usage.
Please review. Thanks!
Andrii Momotov → created an issue.
Added "authors" section to composer.json file.
Please review. Thanks!
Andrii Momotov → created an issue. See original summary → .
Set up GitLab CI. Please review.
Thanks!
Andrii Momotov → created an issue.
It seems that the issue requires additional work because services added to https://git.drupalcode.org/ for this module report a series of problems:
- Merge request pipeline #78092 passed with warnings
- Code Quality scans found 7 new findings and 7 fixed findings.
- Test summary: 8 failed, 21 total tests
See more details here:
https://git.drupalcode.org/project/reverse_proxy_header/-/merge_requests/5
Therefore, I am changing the status to "Needs work"
Fixed the errors/warnings reported by PHP_CodeSniffer.
Please review. Thanks!
Andrii Momotov → created an issue.
Replace README.txt with README.md file. Please review.
Thanks!
Andrii Momotov → created an issue.
Hi @clarkssquared
You are doing something wrong. I've checked several times and it doesn't show any more warnings or errors.
For example, in your message, the first error says:
FILE: ...s/d9/d9-local/web/modules/contrib/taxonomy_protect/taxonomy_protect.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Please look at my MR:
https://git.drupalcode.org/project/taxonomy_protect/-/merge_requests/3/d...
So you'll see, I added a doc comment to the taxonomy_protect.module file.
Thanks!
Added hook_help(). Please review.
Thanks!
Andrii Momotov → created an issue.
Added composer.json file. Please review.
Thanks!
Andrii Momotov → created an issue.
Set up GitLab CI. Please review.
Thanks!
Andrii Momotov → created an issue.
Fixed the errors/warnings reported by PHP_CodeSniffer.
Please review. Thanks!
Andrii Momotov → created an issue. See original summary → .
Set up GitLab CI. Please review.
Thanks!
Andrii Momotov → created an issue.
Created a composer.json file and included all the required information.
Please review. Thanks!
Andrii Momotov → created an issue. See original summary → .
Replaced README.txt with README.md file and added a bit more information about this module.
Please review. Thanks!
Andrii Momotov → created an issue.
Created the MR with fixed phpcs errors. Please review.
Thanks!
Andrii Momotov → made their first commit to this issue’s fork.
Set up GitLab CI. Please review.
Thanks!
Andrii Momotov → created an issue. See original summary → .
Added composer.json file. Please review.
Thanks!
Andrii Momotov → created an issue.
Created README.md file. Please review.
Thanks!
Andrii Momotov → created an issue. See original summary → .
Resolved issues reported by eslint. Please review the MR.
Thanks!
Andrii Momotov → created an issue.