- Issue created by @mfb
- Status changed to Needs work
about 1 year ago 2:28pm 17 November 2023 - 🇺🇦Ukraine bohart Lutsk, Ukraine
Mark, thanks for raising the topic and providing the use case with `ban` module.
The proposed change sounds entirely reasonable.Here is a great example where another module does the same (switched from event_subscriber to http_middleware to support more use cases):
https://git.drupalcode.org/project/cloudflare/-/commit/0c59e6f187a62e879...It would be fantastic if someone from the community could work on this and provide a merge request.
Thanks! - 🇺🇦Ukraine andrii momotov
Andrii Momotov → made their first commit to this issue’s fork.
- Assigned to andrii momotov
- Merge request !5Issue 3402311: Replace event_subscriber service with http_middleware → (Open) created by andrii momotov
- last update
about 1 year ago 2 fail - Status changed to Needs review
about 1 year ago 9:42am 21 November 2023 - 🇺🇦Ukraine andrii momotov
Replaced event_subscriber service with http_middleware. Please check. Thank you!
- last update
about 1 year ago 2 fail - Issue was unassigned.
- Status changed to Needs work
12 months ago 1:26pm 13 January 2024 - 🇺🇦Ukraine bohart Lutsk, Ukraine
@Andrii Momotov , thanks for your contribution!
Tests are failed, so mark this as "needs work".
- First commit to issue fork.
- last update
12 months ago 2 fail - last update
12 months ago 8 pass - last update
12 months ago 8 pass - Status changed to Needs review
12 months ago 11:01am 16 January 2024 - 🇺🇦Ukraine taraskorpach Lutsk 🇺🇦
The tests are fixed now, please review them. I've added a return type in accordance to the parent interface as well.
- last update
12 months ago 8 pass - Status changed to Needs work
10 months ago 2:43pm 16 March 2024 - 🇺🇦Ukraine andrii momotov
It seems that the issue requires additional work because services added to https://git.drupalcode.org/ for this module report a series of problems:
- Merge request pipeline #78092 passed with warnings
- Code Quality scans found 7 new findings and 7 fixed findings.
- Test summary: 8 failed, 21 total testsSee more details here:
https://git.drupalcode.org/project/reverse_proxy_header/-/merge_requests/5Therefore, I am changing the status to "Needs work"