Should this module be a middleware rather than request event subscriber?

Mark, thanks for raising the topic and providing the use case with `ban` module.
The proposed change sounds entirely reasonable.

Here is a great example where another module does the same (switched from event_subscriber to http_middleware to support more use cases):
https://git.drupalcode.org/project/cloudflare/-/commit/0c59e6f187a62e879...

It would be fantastic if someone from the community could work on this and provide a merge request.
Thanks!

Andrii Momotov → made their first commit to this issue’s fork.

Replaced event_subscriber service with http_middleware. Please check. Thank you!

@Andrii Momotov , thanks for your contribution!

Tests are failed, so mark this as "needs work".

The tests are fixed now, please review them. I've added a return type in accordance to the parent interface as well.

It seems that the issue requires additional work because services added to https://git.drupalcode.org/ for this module report a series of problems:

- Merge request pipeline #78092 passed with warnings
- Code Quality scans found 7 new findings and 7 fixed findings.
- Test summary: 8 failed, 21 total tests

See more details here:
https://git.drupalcode.org/project/reverse_proxy_header/-/merge_requests/5

Therefore, I am changing the status to "Needs work"

elaman → changed the visibility of the branch 1.0.x to hidden.

elaman → changed the visibility of the branch 1.1.x to hidden.

Did MR for 1.1.x with code quality and tests fixed.