Hey Dieter, thank you for reaching out to help. I've added you as a maintainer, as requested.
Fixed in #3487260
elaman → made their first commit to this issue’s fork.
Issue seems to be the fact that when you visit a lesson page (i.e. /node/123). The lesson has no way to know which course it is, if it is used in two or more courses.
Reason for this is that relationship between course and lesson. If you take a course, you can determine what modules it contains, then what lessons each module contains. If you take a lesson, you can determine which modules it is in, then what course it is associated with, but there is no way of knowing which course exactly.
Closing this as resolved.
@pwolanin thank you for catching this. We decided to drop Drupal 9 support as you've suggested. Hopefully in very near future we will Drupal 11 support.
Q1) webpack.config.js shoud've been copied as part of anu_lms_override_component folder in Preparing custom module section.
Q2) Yes, the theme.js contains typography section, which can be configured to have different fonts for headings and body. Check out MUI docs: https://v5.mui.com/material-ui/customization/typography/#variants
Q3) See Q1, but if you did Preparing custom module section, you should have webpack.config.js that has that line: https://git.drupalcode.org/project/anu_lms/-/blob/2.x/examples/anu_lms_o...
Q4) Yes, you would need to override the component responsible for displaying the column using the same method (through webpack.config.js) as the guide describes overriding theme.js.
@leeksoup hi, I've created a draft version of a guide on how to override styles. It requires improvement, however I hope it will give you an understanding of how to move forward. https://www.drupal.org/docs/contributed-modules/anu-lms/override-colors-... →
Please let me know if you have any further questions.
@cmlara I've been working on checking if Simple Reset Password can be made to work with TFA. Created draft MR based on MR, please feel free to check it let me know what needs can be improved to include it in your MR. Thank you
elaman → changed the visibility of the branch 3392427-use-an-eventsubscriber-spr to hidden.
@spleshka done. We had the phpunit issue here https://www.drupal.org/project/anu_lms/issues/3446909 📌 CI/CD has failing phpunit step Needs work all along. Would appreciate if anyone is interested in tackling it. Apart from fixing the pipeline itself, would be also good to schedule the automated tests, to catch failing patches.
Fix PHP 8.3 deprecations by implementing a cleaner solution.
Deprecated: Creation of dynamic property Drupal\Core\Render\Markup::$form_id is deprecated in /var/www/html/web/modules/contrib/themable_forms/themable_forms.module on line 143
Deprecated: Creation of dynamic property Drupal\Core\Render\Markup::$views_display_id is deprecated in /var/www/html/web/modules/contrib/themable_forms/themable_forms.module on line 173
The feature does exist. Thank you for bringing to our attention lack of documentation. The Anu LMS documentation might need a broader improvement, however to address this particular issue, I've added a mention about the linear progression feature in this section: https://www.drupal.org/docs/contributed-modules/anu-lms/create-courses-a... →
Add line to mention "Enable linear progress" feature. Fix #3467178 issue.
Attaching diff for compose.json.
elaman → created an issue.
Hey @kbrodej, thank you. I didn't notice it because this issue was closed. Merged it.
Tested version 3:
- No config changes detected.
- No database updates between 1 and 3 versions.
- Assessment (Quiz) module that uses IEF works well with the version 3.
Updated composer.json to support version 3.
Hey @8bitplateau, happy to see you using our module!
Answering your questions:
1. In the quiz module, can I have multiple question of different types in a page but only have one submit button ? at the moment if I have, for example, a simple question and a check box list question then I get one submit for each question, I'd like just one - is that possible ?
I believe you are adding "Question - " type paragraphs, into a "Lesson" content type. If you try to add multiple questions into a "Quiz" content type, you'd have a single "Submit" button. Important to node that you can have only single "Quiz" per module.
There are more details in the documentation: https://www.drupal.org/docs/contributed-modules/anu-lms/create-courses-a... →
2. For my H5P component success tracking, I am adding a quiz question and hiding it, then setting it's value and submitting it via JS when the component is completed. This gives me the score tracking and also the Next button enable/disbale feature. But ... that is a bit hacky. I'm thinking of having a setting in the H5P paragraph to enable quiz tracking or not, and if it is set then having a hidden form field that is set via JS and has the rest of the quiz tracking features (naviagation and data). Please let me know your thoughts if you have any better ideas of how to achive this in a nice and Anu compliant way ;)
The best way to add new features to Anu is by overriding React components, where you have much better control over UI and state of the components. Please check out the included example module for performing such override: https://git.drupalcode.org/project/anu_lms/-/tree/2.x/examples/anu_lms_o...
Please let me know if I answered you questions. We are happy for you to reach out to us if you any more questions.
I've added a feature to allow users to select icon type between:
- uploaded image (current behavior, default)
- remote image
- html element (option to select between i, div, span
Also I've added icon class setting, to applied to all of these types.
Updated the twig file:
- With new icon type rendering ways.
- Added alt to img tags for accessibility.
- Added aria-label to the html element icon type.
Backward compatibility tested, shouldn't have to change anything and it shouldn't break anything in websites already using this module.
Can you please describe your environment and steps to reproduce the issue?
Updated the MR with proposed changes.
elaman → made their first commit to this issue’s fork.
#3 is working.
#13 is working.
Thank you @aaron.ferris.
Here is the list of patches:
-
🐛
FIx fieldsets overlapping when using Gin admin theme
Needs review
-
🐛
Does not support custom paragraph bundle filtering widgets
Needs review
-
🐛
PHP 8.2 Deprecated function: Creation of dynamic property
RTBC
-
🐛
Error: Call to undefined method Drupal\Core\File\FileSystem::uriScheme()
RTBC
->
🐛
Error: Call to a member function getFileUri() on array in paragraphs_browser_paragraph_type_form_builder()
RTBC
-
🐛
Replace deprecated jquery/once with core/once
RTBC
So, I think we can remove third and last. The others has to be double checked and included if needed.
@karunadave tried to reproduce the issue with versions you've specified in a clean Drupal installation. Can you please provide steps to reproduce.
Another good catch @loze, thank you!
Good catch. The issue was in using usort instead of uasort. Fixed.
Note: please test in clean env or new nodes, as existing votes without vote type will throw errors.
This was resolved by adding a table in the field settings.
Tried with default settings on each page:
- Install clean drupal
- Install votingapi_reaction
- Add field_reaction to the article node type
- Enable "View reactions to field field_test in bundle article of entity type node" for anonymous users.
- Enable "React to field field_test in bundle article of entity type node" for anonymous users.
- Create new Test article.
- Can see the reaction widget on article page.
- Can react once on the article page.
- Can't modify my reaction.
Works as expected.
Tried with clean drupal:
- Install Voting API Reaction
- Add the new Reaction field in "Structure" -> "Comment types" -> "Default comments" -> "Manage fields". (I did not set default value).
- Create a new "Article" node.
- Comment on the article.
- The reaction widget appeared as expected and is working.
elaman → created an issue.
#9 causes error with Paragraph:
TypeError: Drupal\Component\Utility\NestedArray::getValue(): Argument #2 ($parents) must be of type array, null given, called in /var/www/html/web/modules/contrib/paragraphs/src/Plugin/Field/FieldWidget/InlineParagraphsWidget.php on line 1320 in Drupal\Component\Utility\NestedArray::getValue() (line 69 of core/lib/Drupal/Component/Utility/NestedArray.php).
Patch is already included in https://www.drupal.org/project/rest_entity_recursive →
The updated patch.
Not an input to the issue, just a patch for 10.2.x