"Add another item" button is shown for a field with original ulimited cardinality but limited cardinality defined using this module

Patch for people not comfortable with MR workflow.

Updated patch

I took a look and this seems to make sense to me. I'll do some testing, and would welcome anyone else's feedback as well.

Updated patch

I did a test setting the "Allowed number of values" to unlimited in the field storage settings and set the cardinality limited to 4.
In the entity form, Drupal was displaying 2 fields and the 'Add another item' button before this patch was applied.
Once this patch is applied, I can see the 4 fields displayed.

Updated the patch.

MR needs to be updated for 4.0.x and hopefully those pipeline errors go away

elaman → changed the visibility of the branch 4.0.x to hidden.

elaman → changed the visibility of the branch 3.x to hidden.

elaman → changed the visibility of the branch 3.x to hidden.

I just tested the patch for 4.x, and it still works as expected with the ‘Autocomplete’ widget. I tested it using both the Gin and Claro admin themes.

Almost the entire issue queue seems to be bugs and probably because it lacks test coverage. I'm working on adding some basic coverage so we can wait on those are start new ones too

Kinda seems like a feature request to me that should be configurable. Someone may not want the limit showing all at once.

smustgrave → closed merge request !8

I’ve added a new configuration option to the Entity Reference field settings that allows site builders to enable the behavior of displaying all field instances. This functionality is currently scoped to Entity Reference fields only, as extending it to other field types would require a more significant refactor across multiple widget implementations.

I’ve also added test coverage for this new setting, following the structure of the existing tests.

Will need a post-update hook also. Should use ConfigImporter to do it batches