🇺🇦Ukraine @bohart

greggles → credited bohart → .

Thanks for your contribution.

1) It looks like we should check for the first valid IP address in some foreach (instead of picking up the first address in the list and checking its validity), isn't it?

2) The maintainer of this module works only with Merge requests (instead of patch files).

Looking forward,

Thanks, fixed!

Committed to 2.3.x branch, the issue does not exist at 2.2.x branch.

Nice catch. Committed. Thanks!

bohart → changed the visibility of the branch 3427635-readme.md-code-snippet-helptext to active.

bohart → changed the visibility of the branch 3427635-readme.md-code-snippet-helptext to hidden.

bohart → made their first commit to this issue’s fork.

bohart → made their first commit to this issue’s fork.

2.3.x branch is green now. Thanks.

bohart → made their first commit to this issue’s fork.

This one is tricky :)
The changes have been committed to both 2.2.x and 2.3.x branches.
Thanks!

bohart → made their first commit to this issue’s fork.

This one is covered at 📌 Automated Drupal 11 compatibility fixes for reroute_email RTBC . Thanks.

The logo has been committed to 2.3.x branch.
It will be a part of 2.3.0-rc2 release (to be released soon).
Thanks!

bohart → made their first commit to this issue’s fork.

All the changes needed for D11 have been committed at #3455294-21: Automated Drupal 11 compatibility fixes for reroute_email → .
Please see all the details on that issue.

Thanks.

Drupal 11 compatibility fixes have been committed to 2.3.x branch.
The minimum required Drupal version for 2.3.x branch is set to D10.2 (due to changes from 📌 [PHPUnit 10] Provide a static alternative to randomMachineName() and implement in data providers Fixed ).
The previous Drupal version (>9.4 and <10.2) is still supported within 2.2.x branch.

If no objection comes, all of those changes will be a part of 2.3.0-rc2 release (to be released soon).
Thanks!

bohart → made their first commit to this issue’s fork.

abyss → credited bohart → .

Legacy comment: in July we provided the archive with high-quality photos from Drupal events in Lutsk (Ukraine).

abyss → credited bohart → .

bohart → created an issue. See original summary → .

Merged. The changes will be a part of the next module release. Thanks!

Merged. The changes will be a part of the next module release. Thanks!

After the latest changes at 8.x-1.x-dev branch, it looks like all changes at DuplicateRoleForm.php and .gitlab-ci.yml files must be removed from MR !7.

Marking this one as Needs work.

phpstan job will be fixed at 📌 Drupal 11 compatibility Active and PHPUnit in a separate issue.

The code has been committed and will be a part of the next module release.

@alt.dev, thanks!

1) Drupal 8 reached its EOL; so we can avoid its requirements.
A new arrow function syntax was introduced in PHP 7.4. So I bet it's okay to use the arrow syntax here.

2) I bet Role::loadMultiple should be replaced with entityTypeManager->getStorage('user_role')->loadMultiple();. Still, this is not a blocker here.

I'm going to merge those changes in the nearest weeks + create a new issue to have ci-cd for coding standards checks later.
Then, if no one object here, altogether will be released as a new 1.4 release of this module.

Thanks!

bohart → created an issue. See original summary → .

If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required.
© drupal-org documentation

1) There is no need to commit composer.json to the module, as it will be generated by drupal-org packegist.
Are there any reasons for adding and maintaining the composer.json file?

2) The 2.2.x branch should not break the work with D9/D10, and its Drupal core version_requirement is not supposed to be lower than in 2.3.x (to follow semantic versioning).
All the changes must be committed either to 2.3.x only (if they break D9/D10) or to both 2.2.x/2.3.x (if they are valid for all D9/D10/D11).

@Rajeshreeputra, please do not create any new releases while we're proceeding with the topics above.

Null coalescing operator has been added in PHP 7, so we can safely use it on 2.3.x branch.

The change (an additional check) has been added to the 2.3.x development branch, and it will be a part of the next 2.3 release series.

If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required.

© drupal-org documentation

Why do we need this change at all to this module?
The task description does not state the reasons for this change.
Could you please clarify? Thanks!

bohart → created an issue.

bohart → created an issue.

bohart → created an issue.

bohart → created an issue.

Added a few comments for better future maintainability.

bohart → created an issue.

bohart → created an issue.

The majority of the issues reported by phpstan have been fixed and committed.
The remaining issues will be fixed at:
- 🐛 Private Message formState storage isn't populated with the members widget data Needs work
- 📌 Replace \Drupal::currentUser() with dependency injection at src/Service/PrivateMessageService.php Needs review
- 📌 Move rule support into a new submodule (or remove it) Active
- 📌 Call to deprecated function user_role_names() Active
- 📌 Constructor of class PrivateMessageAccessControlHandler has an unused parameters Active
- 📌 DI problems Needs review

As this MR is not mergeable anymore, let's simplify this issue.

"\Drupal::currentUser(" should be fixed at 📌 Replace \Drupal::currentUser() with dependency injection at src/Service/PrivateMessageService.php Needs review

The goal of this issue is to fix `PrivateMessageThread::load` only.

Thanks!

@Mohd Sahzad , please be respectful to `Assigned` field of the issues.
If it is chosen, that means someone already works on it. Thanks!

bohart → created an issue.

bohart → created an issue.

bohart → created an issue.

bohart → created an issue.

Hi @artem_sylchuk,
Something went wrong on this issue.

The commit added this line:
if (empty($storage['field_storage']['#parents']['#fields']['members'])) {

But variable $storage is always empty (as it is never defined).
Should we move `$storage = $form_state_copy->getStorage();` above the if or completely remove those lines?

Thanks!

PHPCS job is now green.

Still, there are some issues with eslint, stylelint and phpstan. They will be processed at:
- 📌 Fix the issues reported by phpstan Active

Thanks all!

bohart → created an issue.

bohart → changed the visibility of the branch private_message_phpcs_fix33179853317985 to hidden.

bohart → changed the visibility of the branch 3317985-3.0.x-fix-cs to hidden.

bohart → changed the visibility of the branch private_message_fix_phpcs-33179853317985 to hidden.

bohart → changed the visibility of the branch private_message_phpcs_fix-33179853317985 to hidden.