Contrib.social

Does ReverseProxyHeaderClientIpRestore need the GuzzleHttp Client?

Open on Drupal.org →
Created on 14 July 2021, almost 4 years ago
Updated 7 July 2023, almost 2 years ago

Problem/Motivation

Looks like there may be some leftover copy-paste in the event subscriber?

Steps to reproduce


namespace Drupal\reverse_proxy_header\EventSubscriber;

use Drupal\Core\Site\Settings;
use GuzzleHttp\ClientInterface;
use Psr\Log\LoggerInterface;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Symfony\Component\HttpKernel\Event\RequestEvent;
use Symfony\Component\HttpKernel\KernelEvents;

/**
 * Restores the true client IP address.
 */
class ReverseProxyHeaderClientIpRestore implements EventSubscriberInterface {

  /**
   * The HTTP client to fetch the feed data with.
   *
   * @var \GuzzleHttp\ClientInterface
   */
  protected $httpClient;

Proposed resolution

Remove the references to the Guzzle http client if they're not necessary.

Remaining tasks

commit a fix etc..

User interface changes

n/a

API changes

n/a

Data model changes

n/a

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom mcdruid 🇬🇧🇪🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024