- Issue created by @Project Update Bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module ā these changes make this module compatible with Drupal 11! š
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot ā to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- š®š³India deepakkm
deepakkm ā changed the visibility of the branch project-update-bot-only to hidden.
- First commit to issue fork.
- First commit to issue fork.
- Status changed to RTBC
about 2 months ago 9:10am 17 July 2024 - š®š³India vishalkhode
Reviewed changes, looks good to me. Hence, RTBC.
-
Rajeshreeputra ā
committed 9c6ed46a on 2.2.x authored by
deepakkm ā
Issue #3434204: Automated Drupal 11 compatibility fixes for...
-
Rajeshreeputra ā
committed 9c6ed46a on 2.2.x authored by
deepakkm ā
- Status changed to Fixed
about 2 months ago 8:37am 23 July 2024 - š®š³India Rajeshreeputra Pune
The changes look good, have been verified, and are working as expected. I will proceed with the merge, and we look forward to a release soon with a stable D11-compatible version.
- š®š³India vishalkhode
@Rajeshreeputra @bohart Can we please get a stable/RC release for the same ? Thanks.
- Status changed to Needs work
about 1 month ago 8:01am 29 July 2024 - šŗš¦Ukraine bohart Lutsk, Ukraine
If a module does not have any dependencies, or the dependencies are solely other Drupal modules, then a composer.json is not required.
Ā© drupal-org documentation1) There is no need to commit composer.json to the module, as it will be generated by drupal-org packegist.
Are there any reasons for adding and maintaining the composer.json file?2) The 2.2.x branch should not break the work with D9/D10, and its Drupal core version_requirement is not supposed to be lower than in 2.3.x (to follow semantic versioning).
All the changes must be committed either to 2.3.x only (if they break D9/D10) or to both 2.2.x/2.3.x (if they are valid for all D9/D10/D11).@Rajeshreeputra, please do not create any new releases while we're proceeding with the topics above.
- š®š³India Rajeshreeputra Pune
@bohart,
1) There is no need to commit composer.json to the module, as it will be generated by drupal-org packegist.
Are there any reasons for adding and maintaining the composer.json file?Having a composer.json can simplify the local development process, CI/pipeline when using vcs paths.
2) The 2.2.x branch should not break the work with D9/D10, and its Drupal core version_requirement is not supposed to be lower than in 2.3.x (to follow semantic versioning).
All the changes must be committed either to 2.3.x only (if they break D9/D10) or to both 2.2.x/2.3.x (if they are valid for all D9/D10/D11).Agree with you, š Automated Drupal 11 compatibility fixes for reroute_email RTBC will be completed to support same core_version_requirement.
- š®š³India vipin.mittal18 Greater Noida
@bohart: I also believe that including a composer.json file in your Drupal module can still offer several benefits, even though it might be generated or handled by tools like drupal-org packagist.
- š®š³India vipin.mittal18 Greater Noida
@bohart, Can we get a stable release of the reroute email module 2.2.x now that all requirements for Drupal 11 readiness have been addressed?