- Issue created by @mondrake
- @mondrake opened merge request.
- Assigned to mondrake
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:56pm 13 April 2023 - 🇺🇸United States smustgrave
There a way to get this to run against phpunit 10?
- 🇮🇹Italy mondrake 🇮🇹
#5 does not make sense… we are doing this to be able to support PHPUnit 10, like other patches. Individual patches will not pass against it.
- Status changed to RTBC
over 1 year ago 1:37pm 14 April 2023 - 🇺🇸United States smustgrave
Ah good point. Guess we will fix what we can can and see what was missed when updated.
Tried do a spot check through the tests searching for "function provider" (to start) and find any that aren't using random but didn't see any. So can go ahead and mark this as trust what you are doing here.
- 🇮🇹Italy mondrake 🇮🇹
Guess we will fix what we can can and see what was missed when updated.
Yes... one step after another... :)
- Status changed to Needs review
over 1 year ago 8:39am 15 April 2023 37:44 36:29 Running- last update
over 1 year ago 29,282 pass, 2 fail - last update
over 1 year ago 29,300 pass 22:43 19:09 Running- last update
over 1 year ago 29,300 pass - last update
over 1 year ago 29,361 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,367 pass - last update
over 1 year ago 29,374 pass - Status changed to Fixed
over 1 year ago 12:32pm 4 May 2023 - 🇬🇧United Kingdom catch
Added a belated change record here: https://www.drupal.org/node/3358180 →
I think we need a follow-up to discuss what if anything we want to deprecate, so tagging for that.
- 🇮🇹Italy mondrake 🇮🇹
Filed 📌 [META] Deprecate non-static random generation methods from RandomGeneratorTrait Active for follow up.
Automatically closed - issue fixed for 2 weeks with no activity.