#PHPUnit 10

Hi @larowlan
I also worked on a child issue ( #3489287 📌 Method getMockForAbstractClass() is deprecated - replace in class EntityStorageBaseTest Active ) and was credited on that issue but I think you forgot to add credit here when you credited everyone who worked on a child issue.
Could you please look into it.
Thanks.

Committed to 11.x - thanks!

larowlan → credited anish.ir → .

larowlan → credited catch → .

larowlan → credited deepali sardana → .

larowlan → credited prashant.c → .

larowlan → credited quietone → .

larowlan → credited spokje → .

Crediting everyone who worked on a child issue

Thanks all

larowlan → closed merge request !10297

Committed to 11.x
Congratulations on your first core commit credit @deepali sardana - 💪

larowlan → closed merge request !10660

All child issues aren now RTBC.

Great work on all these!

Feedback appears to be addressed.

Pipeline failures were random and change LGTM.

@deepali sardana patches are deprecated, https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... → , please use th MR process instead.

I have replaced the method getMockForAbstractClass() please review the patch and let me know

Opened issue for last remaining usage, 📌 Method getMockForAbstractClass() is deprecated - replace in class SqlContentEntityStorageTest Active .

Committed to 11.x - thanks!

larowlan → closed merge request !10305

Return types appear to have been added.

quietone → closed merge request !7286

quietone → closed merge request !7322

The PHPStan is now passing, Moving it to NR

Removed the Baseline entry for StubEntityStorageBase as suggested

The PHPStan job is failing, because the new return type introduced makes the added entry on the PHPStan baseline no longer needed. Needs to remove that entry (or regenerate the baseline).

Hey @quietone,
I have added the return type to the new methods in the Stub file as requested.
Please review.

Hey,

I have added the return types to the stub file as suggested.
Please review.

anish.ir → made their first commit to this issue’s fork.

There should be return types on the new methods.

I think there should be return types on the new methods in the stub file.

quietone → closed merge request !9833

@mondrake, thanks for keeping this up to date.

Committed to 11.x and cherry-picked to 11.1.x

Thanks!