- Issue created by @mondrake
- Status changed to Needs review
8 months ago 2:26pm 25 March 2024 - 🇮🇹Italy mondrake 🇮🇹
Let's do a first step and target the usage of the method to create mocks against interfaces - which is nonsense (probably leftover from earlier conversions/creation of interfaces): when you mock an interface you create anyway doubles for all the methods declared on the interface. No abstract classes here, really.
- Status changed to Needs work
8 months ago 7:40am 27 March 2024 - 🇳🇱Netherlands spokje
Like the approach, like the MR, but we've might have a few stragglers (at least, if I understand the scope correctly):
-
\Drupal\Tests\Component\Plugin\Discovery\StaticDiscoveryDecoratorTest::testGetDefinition
: https://git.drupalcode.org/project/drupal/blob/b73c68de45491739c0752d859... and https://git.drupalcode.org/project/drupal/blob/b73c68de45491739c0752d859...
-\Drupal\Tests\Core\Entity\Sql\SqlContentEntityStorageTest::testLoadMultiplePersistentCached
: https://git.drupalcode.org/project/drupal/blob/654b1f2074ea90b75a8750f2b...
-\Drupal\Tests\Core\Entity\Sql\SqlContentEntityStorageTest::testLoadMultipleNoPersistentCache
: https://git.drupalcode.org/project/drupal/blob/654b1f2074ea90b75a8750f2b...
-\Drupal\Tests\Core\Entity\Sql\SqlContentEntityStorageTest::testLoadMultiplePersistentCacheMiss
: https://git.drupalcode.org/project/drupal/blob/654b1f2074ea90b75a8750f2b...
-\Drupal\Tests\Core\Entity\TypedData\EntityAdapterUnitTest::setUp
: https://git.drupalcode.org/project/drupal/blob/9add7f71ff26864477f80e349... - Assigned to mondrake
- 🇮🇹Italy mondrake 🇮🇹
Thanks @Spokje, the first two OK, indeed; the last three in fact are misleading since in each file
SqlContentEntityStorageTestEntityInterface
is an abstract class defined at the end of each file... very confusing, for that one we need an issue of its own.Fixing the first two.
- Issue was unassigned.
- Status changed to Needs review
8 months ago 8:44am 27 March 2024 - Status changed to RTBC
8 months ago 8:54am 27 March 2024 - 🇳🇱Netherlands spokje
Thanks @mondrake, I'll take a 50% success rate any day...
RTBC for me now.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 35a8fc6dec to 11.x and dd091490e5 to 10.3.x and 5d04815308 to 10.2.x. Thanks!
Backported to 10.2.x to keep tests aligned.
-
alexpott →
committed 5d048153 on 10.2.x
Issue #3433088 by mondrake, Spokje: Method getMockForAbstractClass() of...
-
alexpott →
committed 5d048153 on 10.2.x
-
alexpott →
committed dd091490 on 10.3.x
Issue #3433088 by mondrake, Spokje: Method getMockForAbstractClass() of...
-
alexpott →
committed dd091490 on 10.3.x
- Status changed to Fixed
8 months ago 1:28pm 27 March 2024 -
alexpott →
committed 35a8fc6d on 11.x
Issue #3433088 by mondrake, Spokje: Method getMockForAbstractClass() of...
-
alexpott →
committed 35a8fc6d on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.