- Issue created by @mondrake
- First commit to issue fork.
- Merge request !7465Replace catch of PHPUnit\Framework\Error\Warning in ViewExecutableTest → (Closed) created by quietone
- 🇮🇳India samit.310@gmail.com
samit.310@gmail.com → made their first commit to this issue’s fork.
- Status changed to Needs review
8 months ago 8:40am 15 April 2024 - 🇳🇿New Zealand quietone
@samit.310@gmail.com, It is much easier to follow changes if we all use the same MR. That is, unless doing something like trying a completely new approach.
I am closing MR 7465.
- 🇳🇿New Zealand quietone
Like similar issues this is happening at runtime so changed to logging an error.
- Status changed to RTBC
8 months ago 1:23pm 16 April 2024 - 🇺🇸United States smustgrave
Didn't have a chance to dig through if exception was needed but think logging is much safer.
LGTM
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
E_USER_WARNING replaced with a logged warning makes sense. Nice. And thanks for re-titling the issue to be about the change and not the tests.
Committed and pushed 56c078e592 to 11.x and 99dea2fa41 to 10.3.x. Thanks!
-
alexpott →
committed 99dea2fa on 10.3.x
Issue #3440041 by quietone, mondrake: Log warning for an invalid view...
-
alexpott →
committed 99dea2fa on 10.3.x
- Status changed to Fixed
8 months ago 1:37pm 16 April 2024 -
alexpott →
committed 56c078e5 on 11.x
Issue #3440041 by quietone, mondrake: Log warning for an invalid view...
-
alexpott →
committed 56c078e5 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.