Replace calls to ::expectWarning*() from Drupal\Tests\Core\Security\DoTrustedCallbackTraitTest

Working on this.

MR!7011 is for 10.3.x. Once we confirm this is the way to go, I'd add a D11 branch for the removal, à la 📌 Deprecate trigger_error in FileStorage::createDirectory() to allow replacing calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest RTBC .

Change looks fine to me. Do you want to open the 11.x branch also?

I think this should wait until we have found a direction for 📌 Deprecate trigger_error in FileStorage::createDirectory() to allow replacing calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest RTBC .

Sounds good postponing on 📌 Deprecate trigger_error in FileStorage::createDirectory() to allow replacing calls to :::expectWarning*() in Drupal\Tests\Component\PhpStorage\FileStorageTest RTBC

I think we should go ahead and deprecate TRIGGER_WARNING. As far as I can see it was never used in core (except for the test coverage) and can't find any uses in contrib.

MR!7011 for 10.3.x and MR!7399 for 11.x

Removal seems fine, all green.

Commited/pushed to 11.x and 10.3.x respectively, thanks!

There is a change record for this issue that consists of "@tbd"

Whoops. I updated the CR with how to handle the deprecation.

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake → closed merge request !7011