ImageItem logs an warning instead of triggering an E_USER_WARNING

The warning was previously wrapped in EntityStorageException, here we don't change that, we just throw a real exception in preSave() instead.

Seems straight forward.

Let's say we add a core update in three months which calls this code, and you have a site where the file has gone missing from an image field (very likely given our ten years of file_usage being broken and randomly deleting files, or if you install file delete module and mistakenly delete a file in use). With the current code, the update will complete, but tell you something is wrong, but with the MR, the update will fail and your database is now in an unrecoverable state - you can't roll back the update and you can't complete it, so you'd have to restore a backup, if you have one.

We either need to keep the warning here, maybe by using the logger, or refactor the test coverage.

Thanks, this version looks good to me.

Committed and pushed 0298c95971 to 11.x and fea64b66ce to 10.3.x. Thanks!

longwave → closed merge request !7463

Automatically closed - issue fixed for 2 weeks with no activity.