- Issue created by @mondrake
- Status changed to Needs review
4 months ago 4:40pm 31 August 2024 - Status changed to RTBC
4 months ago 7:43pm 31 August 2024 - 🇺🇸United States smustgrave
Seems like a good replacement. Least coverage isn't lost to me.
- 🇬🇧United Kingdom catch
Shame we have to suppress the @internal deprection notice but don't see a way around that.
Committed/pushed to 11.x, thanks!
- Status changed to Fixed
3 months ago 4:15pm 13 September 2024 - Status changed to RTBC
3 months ago 4:25pm 13 September 2024 - 🇬🇧United Kingdom catch
Oh good point - the commit failed locally on commit checks:
Running PHPStan on *all* files. ------ ------------------------------------------------------------------- Line core/tests/Drupal/Tests/Core/Template/StubTwigTemplate.php ------ ------------------------------------------------------------------- 39 Method Drupal\Tests\Core\Template\StubTwigTemplate::doDisplay() should return iterable<bool|float|int|string|Stringable|null> but return statement is missing. 39 Return type mixed of method Drupal\Tests\Core\Template\StubTwigTemplate::doDisplay() is not covariant with return type iterable of method Twig\Template::doDisplay(). ------ -------------------------------------------------------------------
This is probably due to the twig update this week.
- Status changed to Needs work
3 months ago 5:45pm 13 September 2024 - Status changed to Needs review
3 months ago 7:08pm 13 September 2024 - Status changed to RTBC
3 months ago 5:54pm 16 September 2024 - 🇺🇸United States smustgrave
pipeline appears green. coverage isn't lost to me.
- Status changed to Fixed
3 months ago 6:01pm 16 September 2024 - 🇬🇧United Kingdom catch
Thanks for the rebase. Committed/pushed to 11.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.