- Issue created by @longwave
- Merge request !7573Convert MailHandlerTest::getSendMailMessages() to static. → (Closed) created by longwave
- 🇬🇧United Kingdom longwave UK
This one was quite fiddly but got there in the end.
The change to ::getAuthenticatedMockMessage() is strange and I can't quite explain it. The mocked ContactFormInterface now fails its expectations if you leave it in place, but when I traced the code through
::getContactForm()
was never called in the authenticated user case, so the expectations were never met in the first place, unsure how this was passing before. - Status changed to Needs review
5 months ago 9:06am 18 April 2024 - 🇬🇧United Kingdom longwave UK
...and managed to refactor it further from here to make the dataprovider much easier to follow.
- Status changed to RTBC
5 months ago 9:31pm 19 April 2024 - 🇺🇸United States smustgrave
This one was a little more but updates to use booleans and arrays vs MessageInterface does appear much cleaner. Will lean on the tests showing green that nothing broke.
LGTM
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed 54da986560 to 11.x and d404c50e5c to 10.3.x and 3781898992 to 10.2.x. Thanks!
Backported to 10.2.x to keep test coverage aligned.
-
alexpott →
committed 37818989 on 10.2.x
Issue #3441660 by longwave: [PHPUnit 10] Provide a static alternative to...
-
alexpott →
committed 37818989 on 10.2.x
-
alexpott →
committed d404c50e on 10.3.x
Issue #3441660 by longwave: [PHPUnit 10] Provide a static alternative to...
-
alexpott →
committed d404c50e on 10.3.x
- Status changed to Fixed
5 months ago 9:13am 21 April 2024 -
alexpott →
committed 54da9865 on 11.x
Issue #3441660 by longwave: [PHPUnit 10] Provide a static alternative to...
-
alexpott →
committed 54da9865 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.