Running the unit test JsonLogTest.php produces an additional deprecation running PHPUnit version 10:
Test Triggered PHPUnit Deprecation (Drupal\Tests\jsonlog\Unit\JsonLogTest::testLogChannelFilter)
Data Provider method Drupal\Tests\jsonlog\Unit\JsonLogTest::logChannelFilterProvider() is not static
Run jsonlog/tests/src/Unit/JsonLogTest.php with PHPUnit Version 10 on Drupal 11
Easy fix to make the function static.
Does not introduce a deprecation.
Also good to remove unused use statements.
X Create issue fork
X Create Merge Request
- Test
- Merge into 4.x-dev
None
None
None
Needs review
4.0
Code
This looks good to me.
Potentially setting core_version_requirement to ^10.3 || ^11 might help for the next stable release as well in case anyone one who hasn't gotten to 10.3 tries to update and runs tests. That could also be done in the other issue as well.