Remove Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource()

Not sure I 100% know that error but phpstan error

Yeah, phpstan doesn't like this, so we need to add it to the baseline.

The @phpstan-ignore-next-line (on the line before the method declaration, not the @dataprovider line worked when I ran the commit check script, but the CI doesn't like it, and I haven't gotten back to figuring out why yet.

Ah, because the commit check only checks the changed files, but another abstract class, MigrateSqlSourceTestBase extends MigrateSourceTestBase, and throws the same error now when all files are checked, and the names were similar enough that I didn't notice CI was complaining about a completely different file.. Okay, I added both to the baseline. Hopefully, this one works.

Good find! All green and change seems fine to me.

Makes sense, I opened 📌 Add back Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource() Active for 10.4 and 110/11.1 since we should be able to do that when we're going to drop 10.2 support.

Automatically closed - issue fixed for 2 weeks with no activity.

Unfortunately the BC layer here only works in one direction, when the method is declared as non-static.

When you try to make it static for D11 then the tests fail on 10.2 with:

PHP Fatal error: Cannot make non static method Drupal\Tests\migrate\Kernel\MigrateSourceTestBase::providerSource() static in class Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest in /builds/project/paragraphs/tests/src/Kernel/migrate/ParagraphsTypeSourceTest.php on line 25

See https://git.drupalcode.org/project/paragraphs/-/jobs/1683642.

Can we backport this to 10.2.x as well?

I think it's safe to backport, it's almost entirely a docs change, removing an abstract method can't affect anything. However it needs a backport MR, 10.3.x commit doesn't cherry-pick cleanly.

mikelutz → changed the visibility of the branch 3437129- to hidden.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Thanks!

catch → closed merge request !8182

Committed/pushed to 10.2.x, thanks!

Thanks for the quick turnaround. I can confirm that paragraph tests can be run against 10.2/10.3/11.0 (with varying amount of fails on all branches, but they *run*)

Automatically closed - issue fixed for 2 weeks with no activity.