- Issue created by @longwave
- Status changed to Needs review
8 months ago 10:42am 26 April 2024 - 🇬🇧United Kingdom longwave UK
Here we don't need mocks but we are testing instance methods directly, the only thing I could see to do here is move the cases into the test method and run them via a foreach loop.
- Status changed to RTBC
8 months ago 10:55am 26 April 2024 - 🇮🇹Italy mondrake 🇮🇹
Pity that we can no longer use a dataprovider here, but given the choice to make these static methods, this seems sensible. Thanks
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks!
This doesn't cherry-pick to 10.3.x, moving to 'to be ported', since we might as well do that at some point.
- Status changed to Downport
8 months ago 2:56pm 26 April 2024 - Status changed to Needs review
8 months ago 12:32pm 1 May 2024 - Status changed to RTBC
8 months ago 1:53pm 1 May 2024 - Status changed to Fixed
8 months ago 2:15pm 1 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.