- Issue created by @mondrake
- Status changed to Needs review
6 months ago 10:52am 23 March 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
I think this could be further simplified removing reflectionโฆ not sure here is the right place though.
- Status changed to Needs work
6 months ago 11:04am 23 March 2024 - Status changed to Needs review
6 months ago 11:44am 23 March 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
It's a broader refactoring but given there's only an instance of this method used in core, I thought it can be acceptable.
- Status changed to RTBC
6 months ago 11:49am 24 March 2024 - ๐ณ๐ฑNetherlands Spokje
MR actually extends the existing test-coverage and replaces the (as said) only occurrence of
getObjectForTrait()
. - Status changed to Fixed
6 months ago 10:32am 25 March 2024 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Committed and pushed 2dad474438 to 11.x and 74631a1331 to 10.3.x and 503f885f52 to 10.2.x. Thanks!
Backported to 10.2.x to keep tests aligned.
-
alexpott โ
committed 503f885f on 10.2.x
Issue #3433093 by mondrake: Method getObjectForTrait() of class PHPUnit\...
-
alexpott โ
committed 503f885f on 10.2.x
-
alexpott โ
committed 74631a13 on 10.3.x
Issue #3433093 by mondrake: Method getObjectForTrait() of class PHPUnit\...
-
alexpott โ
committed 74631a13 on 10.3.x
-
alexpott โ
committed 2dad4744 on 11.x
Issue #3433093 by mondrake: Method getObjectForTrait() of class PHPUnit\...
-
alexpott โ
committed 2dad4744 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.