- Issue created by @longwave
- Status changed to Needs review
about 2 months ago 2:32pm 25 April 2024 - 🇬🇧United Kingdom longwave UK
Not even sure what this is testing, I don't see where
entityorentity_typeis ultimately used, and the test confirms it makes no difference to the output anyway, so I think just putting an empty object in here is fine. - Status changed to RTBC
about 2 months ago 4:58pm 25 April 2024 - 🇺🇸United States smustgrave
Didn't seem to break anything. Seems straight forward enough
- Status changed to Fixed
about 2 months ago 8:49pm 25 April 2024 - 🇬🇧United Kingdom catch
The MR is fine, but this is testing dead (or at least redundant) code in views.
core/modules/views/src/Plugin/views/field/FieldPluginBase.php does handle $options['entity'], but only to pass it around, not to do anything with it.
And the reason it does that is to support
entity_uri(), which hasn't existed since Drupal 7 https://api.drupal.org/api/drupal/includes%21common.inc/function/entity_...But let's go ahead here and deal with that in the follow-up, opened 📌 Remove entity_uri() support from views because it hasn't existed since 2012 Active .
Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.