Remove entity_uri() support from views because it hasn't existed since 2012

Created on 25 April 2024, 2 months ago

Problem/Motivation

See discussion in πŸ“Œ Change @dataprovider to static in MenuAccessControlHandlerTest Fixed .

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs work

Version

11.0 πŸ”₯

Component
ViewsΒ  β†’

Last updated 5 minutes ago

Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • Status changed to Needs work 2 months ago
  • πŸ‡¬πŸ‡§United Kingdom catch

    Removing the code first to see if the test coverage still passes, I think it probably will.

  • Pipeline finished with Running
    2 months ago
    #156829
  • πŸ‡¬πŸ‡§United Kingdom catch

    No wait I'm wrong, or at least, it's not definitely dead/redundant.

    EntityBase::toUrl() still does this:

        // Pass the entity data through as options, so that alter functions do not
        // need to look up this entity again.
        $uri
          ->setOption('entity_type', $this->getEntityTypeId())
          ->setOption('entity', $this);
    
    

    I think this eventually gets passed down as undocumented keys in the $options array in OutboundPathProcessorInterface::processOutbound()
    If that's the case, it might be valid after all, or... we might want to remove entity and entity_type from options in EntityBase::toUrl() instead.

Production build 0.69.0 2024