Change @dataprovider to static in MenuAccessControlHandlerTest

Here, we set up a mock service in the data provider, but only to satisfy assert() - so if we switch assertions off we can avoid the mock altogether.

Nice find.

If the test is running in a separate process are the data providers? I guess they must be... just thinking about this to ensure we don't have unintended side effects.

We could minimise side effects by switching it back on again after creating the data set.

Implemented #7. Note that we also change zend.assertions in FieldTypePluginManagerTest, which is partially where I got the idea for this.

Javascript error appears to be unrelated to this change;.

Tricky one but looks sensible.

Committed/pushed to 11.x, thanks!

longwave → closed merge request !7681

Automatically closed - issue fixed for 2 weeks with no activity.