- Issue created by @mondrake
- Status changed to Needs review
4 months ago 4:30pm 28 July 2024 - Status changed to RTBC
4 months ago 3:02pm 29 July 2024 - 🇺🇸United States smustgrave
Seems straight forward
Wonder if there are other instances that could use StubControllerBase()?
- Status changed to Needs review
4 months ago 5:29pm 29 July 2024 - 🇮🇹Italy mondrake 🇮🇹
Wonder if there are other instances that could use StubControllerBase()?
Found one in the same test, but no further.
- Status changed to RTBC
4 months ago 6:09pm 29 July 2024 - Status changed to Needs work
4 months ago 1:20am 30 July 2024 - Status changed to Needs review
4 months ago 5:13am 31 July 2024 - 🇮🇹Italy mondrake 🇮🇹
#8 copying here reply to the same comment in 📌 Method getMockForAbstractClass() of class PHPUnit\Framework\TestCase is deprecated in PHPUnit 10 - replace in Plugin component tests Needs review :
I have seen multiple classes/namespaces in the same file having problems with Rector, see for instance here https://www.drupal.org/project/drupal/issues/3446693 📌 Convert test annotation to attributes in Drupal/Test/Component Needs work where rector could not write 'use' imports, FQCN are written instead, and we'll be having to manage that manually.
So if it's not a big problem I'd rather go for a separate file, which IMHO is also more gentle to autoloading and readibility.
- Status changed to RTBC
4 months ago 1:31pm 6 August 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!
- Status changed to Fixed
4 months ago 12:57am 7 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.