- Issue created by @mondrake
- Status changed to Needs work
about 1 year ago 10:16pm 11 May 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
The @medium annotations can no longer be associated to methods, as attributes.
Only to classes. - ๐ฎ๐นItaly mondrake ๐ฎ๐น
MR merged with ๐ TestDiscovery expects @group annotations, fails with #[Group()] attributes Active to check with TestDiscovery suppoorting #[Group] attributes.
- Status changed to Needs review
about 1 year ago 11:59am 29 May 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
This is blocked by ๐ TestDiscovery expects @group annotations, fails with #[Group()] attributes Active , tests with only attributes break the test discovery.
However, the MR is the pure output of the rector script indicated in the IS. So a review would be welcome - to incorporate feedback to the script.
- Status changed to Needs work
12 months ago 10:34am 2 June 2024 The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.
- Status changed to Postponed
12 months ago 12:52pm 2 June 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Keeping the @group annotations in for the moment, tests are passing.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
mondrake โ changed the visibility of the branch 3446693-convert-test-annotation to hidden.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
mondrake โ changed the visibility of the branch 3446693-convert-test-annotation to active.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น
It seems PHPUnit does not like files where multiple namespaces are defined (e.g. the test namespace + test class + a fixture namespace to work around SUT).
BTW, neither Rector does: it fails to determine the โmainโ namespace and therefore forces the use of FQCN while adding attributes, instead of adding an
use
import + attribute short class name.Maybe for now we just skip converting those cases.
Weird that we get this only while moving to attributes.
- ๐ฎ๐นItaly mondrake ๐ฎ๐น