[PP-1] Convert test annotation to attributes in Drupal/Test/Component

Created on 11 May 2024, 7 months ago
Updated 8 September 2024, 3 months ago

Problem/Motivation

Please DO NOT change the MR here manually. The intent here is to develop a Rector script to automatically do the conversions. The script itself is currently being developed at https://github.com/mondrake/d8-unit/blob/test-rector/rector.php

We need first to find out all the blockers for such automation to happen.

Blocked by:

Done:

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Postponed

Version

11.0 🔥

Component
PHPUnit 

Last updated about 22 hours ago

Created by

🇮🇹Italy mondrake 🇮🇹

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mondrake
  • 🇮🇹Italy mondrake 🇮🇹
  • Merge request !8033Closes #3446693 → (Open) created by mondrake
  • Pipeline finished with Failed
    7 months ago
    Total: 193s
    #170724
  • Status changed to Needs work 7 months ago
  • 🇮🇹Italy mondrake 🇮🇹

    The @medium annotations can no longer be associated to methods, as attributes.
    Only to classes.

  • Pipeline finished with Failed
    7 months ago
    Total: 196s
    #170847
  • Pipeline finished with Failed
    7 months ago
    Total: 177s
    #170854
  • Pipeline finished with Failed
    7 months ago
    Total: 192s
    #170876
  • Pipeline finished with Failed
    7 months ago
    Total: 187s
    #170908
  • Pipeline finished with Failed
    7 months ago
    Total: 175s
    #170957
  • Pipeline finished with Failed
    7 months ago
    Total: 172s
    #170962
  • Pipeline finished with Failed
    7 months ago
    Total: 502s
    #170964
  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Failed
    7 months ago
    Total: 702s
    #174313
  • 🇮🇹Italy mondrake 🇮🇹

    MR merged with 📌 TestDiscovery expects @group annotations, fails with #[Group()] attributes Active to check with TestDiscovery suppoorting #[Group] attributes.

  • Pipeline finished with Failed
    7 months ago
    Total: 663s
    #174355
  • Pipeline finished with Failed
    7 months ago
    Total: 194s
    #177405
  • Pipeline finished with Failed
    7 months ago
    Total: 191s
    #182003
  • Pipeline finished with Failed
    7 months ago
    #182102
  • Pipeline finished with Failed
    7 months ago
    Total: 369s
    #182120
  • Pipeline finished with Failed
    7 months ago
    Total: 165s
    #182195
  • Pipeline finished with Failed
    7 months ago
    Total: 202s
    #182210
  • Pipeline finished with Failed
    7 months ago
    Total: 458s
    #182215
  • 🇮🇹Italy mondrake 🇮🇹
  • 🇮🇹Italy mondrake 🇮🇹
  • Pipeline finished with Failed
    7 months ago
    Total: 335s
    #182480
  • Pipeline finished with Failed
    7 months ago
    Total: 162s
    #182491
  • Pipeline finished with Success
    7 months ago
    Total: 441s
    #182494
  • Pipeline finished with Success
    7 months ago
    Total: 350s
    #182513
  • Pipeline finished with Failed
    7 months ago
    Total: 392s
    #185002
  • Status changed to Needs review 7 months ago
  • 🇮🇹Italy mondrake 🇮🇹

    This is blocked by 📌 TestDiscovery expects @group annotations, fails with #[Group()] attributes Active , tests with only attributes break the test discovery.

    However, the MR is the pure output of the rector script indicated in the IS. So a review would be welcome - to incorporate feedback to the script.

  • 🇮🇹Italy mondrake 🇮🇹
  • Status changed to Needs work 7 months ago
  • The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • Status changed to Postponed 7 months ago
  • 🇮🇹Italy mondrake 🇮🇹
  • 🇮🇹Italy mondrake 🇮🇹

    Keeping the @group annotations in for the moment, tests are passing.

  • Pipeline finished with Success
    4 months ago
    Total: 3002s
    #273380
  • 🇮🇹Italy mondrake 🇮🇹

    mondrake changed the visibility of the branch 3446693-convert-test-annotation to hidden.

  • 🇮🇹Italy mondrake 🇮🇹

    mondrake changed the visibility of the branch 3446693-convert-test-annotation to active.

Production build 0.71.5 2024