- Issue created by @mondrake
- Status changed to Needs review
7 months ago 2:23pm 8 June 2024 - 🇬🇧United Kingdom longwave UK
We will need a change record as anyone with a custom phpunit.xml will need to add this.
I wonder if we should configure it with the extension configuration instead of using environment variables, or perhaps support both methods?
Let's also let @alexpott confirm that this solves the problem he found with paratest.
- 🇮🇹Italy mondrake 🇮🇹
+1 on adding config parameters in the xml, and deprecating the two environment variables.
- 🇬🇧United Kingdom longwave UK
Re: the change record and custom phpunit.xml, I wonder if we can detect from bootstrap.php or elsewhere that the extension is not loaded, and print some kind of notice.
- 🇮🇹Italy mondrake 🇮🇹
I've tried #7 for deprecating BROWSERTEST_OUTPUT_VERBOSE, although one may argue this is not really a deprecation since there is no point release using it yet.
Deprecating BROWSERTEST_OUTPUT_DIRECTORY is somehow more complicated, since its value is set dynamically in code by PhpUnitTestRunner - for testing purposes and to determine realpath. I'd rather try do that in a follow-up.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
++ this works great and fixes running Drupal tests using paratest. We should definitely do this. Thanks @mondrake.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I've applied this fix to #3452524: Fix tests on 11.x due to PHPUnit 10 → and it works great. See https://git.drupalcode.org/project/distributions_recipes/-/jobs/1822778 for a successful run using paratest.
- Assigned to mondrake
- Status changed to Needs work
7 months ago 3:05pm 10 June 2024 - 🇮🇹Italy mondrake 🇮🇹
Let's see if I can please everyone with the following:
1. Let's have xml parameters for output directory and verbose, with defaults. Verbose = true
2. Let's keep the two env variables as overrides of the xml parameters, if they exist (i.e. no more deprecation)This way we combine both worlds, and on CI we do not have to tamper with the xml file.
On that.
- Issue was unassigned.
- Status changed to Needs review
7 months ago 4:24pm 10 June 2024 - Status changed to RTBC
6 months ago 9:38am 11 June 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
This looks fantastic - nice work @mondrake
Raising this to major as it fixes a regression in Drupal 11. The regression is the ability to use paratest - which works great on D10. I think with this change and the move of deprecation reporting to PHPUnit it might be finally possible to consider removing run-tests.sh in favour of paratest which would be quite amazing.
- 🇮🇹Italy mondrake 🇮🇹
Once this is in, the main CR for PHPUnit 10 will need adjustment.
- Status changed to Needs work
6 months ago 4:01pm 18 June 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
6 months ago 8:38pm 18 June 2024 -
longwave →
committed 72601e5a on 11.0.x
Issue #3453341 by mondrake, alexpott, longwave: Bootstrap...
-
longwave →
committed 72601e5a on 11.0.x
-
longwave →
committed 0bfc9722 on 11.x
Issue #3453341 by mondrake, alexpott, longwave: Bootstrap...
-
longwave →
committed 0bfc9722 on 11.x
- Status changed to Fixed
6 months ago 7:01am 27 June 2024 - 🇬🇧United Kingdom longwave UK
Committed and pushed 0bfc972263 to 11.x and 72601e5aef to 11.0.x. Thanks!
- 🇮🇹Italy mondrake 🇮🇹
Updated the main CR https://www.drupal.org/node/3365413 → to reflect this.
Automatically closed - issue fixed for 2 weeks with no activity.