- 🇩🇪Germany tstoeckler Essen, Germany
...ahh maybe because the MR is targeting 10.1.x. @bradjones1 do you have access to change the target branch? Or should we create a new MR? Not sure...
- 🇩🇪Germany tstoeckler Essen, Germany
Opened a merge request with the change. This will need to be changed to deprecate
setFieldNames()
before it can go in, but I would like some discussion/agreement that this makes sense first, before going ahead with that. Thus, marking "Needs review". - @tstoeckler opened merge request.
- 🇩🇪Germany tstoeckler Essen, Germany
Not sure why the testbot doesn't run for the updated commits, but I opened 📌 Replace DefaultTableMapping::setFieldNames() with ::add*() and ::remove*() Active in the meantime.
- Issue created by @tstoeckler
- 🇩🇪Germany tstoeckler Essen, Germany
Just stumbled upon this. Currently there is not really an easy way to modify the default table mapping, in my opinion. Unless you actually want something radically different providing a different (sub-)class other than
DefaultTableMapping
, while possible, is not actually very helpful, because you may need to copy the entire class just to change a few lines. Having these methods public, currently allows avoiding that and actually making small alterations with just a small amount of code. See 🐛 Cannot use UUID as entity ID Needs review for something that is currently fixable fairly cleanly from custom code which would become impossible, not in principle, but in reality, if these methods were made protected.Since this also does not bring any maintainability gain as far as I can tell, I am against this until we have a different more bespoke API for actually customizing the entity table layout.
- 🇩🇪Germany tstoeckler Essen, Germany
After talking to @rnsrk abou this in Burgas, spent some more time on this.
Fixed the issue mentioned in #9. Also added some inline comments about the changes and finally added some test coverage. I pushed those to individual commits in case there are any objections to any of those.
Note that I thought a bit about how to avoid all this array madness (i.e.
array_values(array_unique(array_filter(...)))
and friends) and I think the solution would be to makeDefaultTableMapping
provide anaddFields()
method, which would internally check for duplicate fields. Will open a follow-up about that, so we can avoid that discussion here (even though it does make the situation (inherently) slightly worse).Not exactly why this was tagged "Needs change record" or what the change record should be. I mean we could literally write a change notice with "Content entities may now use the same field for the ID and UUID keys" if people think that's useful. (I don't, in particular, but it also doesn't hurt, so I wouldn't mind it.)
- First commit to issue fork.
- 🇩🇪Germany tstoeckler Essen, Germany
So as far as I can tell the following is true:
- We have an
email.validator
service that uses egulias' one but does not perform strict validation (it usesRFCValidation()
) - Email form elements use this service
- Email fields do not use the core service but the Symfony constraint which also uses egulias' validator but does perform strict validation (it uses
NoRFCWarningsValidation()
)
The discrepancy between form elements and fields is already very unfortunate in my opinion in it's own right. It get's worse, though, because of the fact that on site install the site email (form element) is used as the user 1 email (field). Thus, you can currently install Drupal using
foo@localhost
as a site (+ user 1) email, but that leaves user 1 in an invalid state. In particular, you cannot submit the user 1 profile form (without changing the email to something else).As far as I can tell, the decision to prefer strict validation in core has already been made by #3307736: EmailValidator defaults to 'loose' mode which is deprecated in Symfony 6.2 → so I think the solution would be to just make the
email.validator
service use strict validation, as well, but holding off on the title and issue summary and the re-classifying as a bug until some confirmation on the proposed the resolution. - We have an
I have observed the test failures, may be we can use:
"commentAccepted/commentEligible/commentAllowed" in place of "Commentable"
As "commentAccepted/commentEligible/commentAllowed" word would be more closer/relative to the "Commentable" word to fix cspell test failures.
Left suggestion not updating MR, as most of the work done already.
- 🇳🇱Netherlands bbrala Netherlands
In the end we need a source of truth. I'd opt for gitlab for that eventually I think. But a maintainers.txt is also usefull for history.
Thanks for adding the related issue, that is usefull.
At some point we should also add codeowners possibly. For the different parts of Drupal I think. But that one for later, and very out of sco0e of this issue.
- 🇫🇷France Grimreaper France 🇫🇷
https://git.drupalcode.org/issue/drupal-3457863/-/jobs/1984798#L4263
---- Drupal\KernelTests\Core\Layout\LayoutPluginManagerTest ---- Status Group Filename Line Function -------------------------------------------------------------------------------- Fail Other phpunit-361.xml 0 Drupal\KernelTests\Core\Layout\Layo PHPUnit Test failed to complete; Error: PHPUnit 10.5.20 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.8 Configuration: /builds/issue/drupal-3457863/core/phpunit.xml.dist F 1 / 1 (100%) Time: 00:01.315, Memory: 8.00 MB There was 1 failure: 1) Drupal\KernelTests\Core\Layout\LayoutPluginManagerTest::testPluginOverride Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'Child' +'Parent' /builds/issue/drupal-3457863/core/tests/Drupal/KernelTests/Core/Layout/LayoutPluginManagerTest.php:40
- 🇫🇷France Grimreaper France 🇫🇷
Provided a MR with a failing test to demonstrate the problem.
- @grimreaper opened merge request.
- Issue created by @Grimreaper
- Issue created by @valthebald
-
dan2k3k4 →
committed ce9d0d46 on staging
Fixes Issue #3404467: Add generic readme based on la_es
-
dan2k3k4 →
committed ce9d0d46 on staging
- 🇳🇱Netherlands ekes
Think that covered them. The additional Unit test for the Negotiator is left, but might just duplicate what is in the Access Policy test.
- 🇧🇪Belgium dtfabio Ninove
Hi Tim,
I tried the code change and the site now asks to turn on file and I no longer get a fatal error.
Greetings,
Fabio
- 🇧🇪Belgium brentg Ghent
Gitlab is added, there are some warnings still, but these will be fixed in another issue
- last update
2 days ago 1 pass - 🇺🇸United States smustgrave
MR appears to have failures but also tagging for test coverage and issue summary update.
Thanks
- last update
2 days ago 1 pass - @tim-diels opened merge request.
- last update
2 days ago 1 pass - last update
2 days ago 1 pass - 5d36abaf committed on 2.0.x
Issue #3457833: Translate config items the correct method
- 5d36abaf committed on 2.0.x
- Issue created by @brentg
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Spellcheck fails, but not sure how to better name this.
- 🇧🇪Belgium dtfabio Ninove
Hi abhiyanshu,
Thanks for doing the work that needed to be done, only I did already mention I was going to take this up.
In the future, it is best that you first check if someone else has not already specified that they are working on this before starting the ticket.
This also ensures no duplication of work, which is certainly important for larger tickets.
It is also best practice to transfer the ticket to "Needs review" after the work has been done, so other developers know it needs to be looked at.
I will test your solution.
Greetings,
Fabio
- First commit to issue fork.
-
pfrenssen →
committed 2e28034c on 8.x-1.x
Issue #3423700 by pfrenssen, gngn: D10 readiness: replace deprecated...
-
pfrenssen →
committed 2e28034c on 8.x-1.x
- last update
2 days ago 73 pass - 🇨🇭Switzerland dan2k3k4 Zurich
Pushed to https://git.drupalcode.org/project/la_pipes/-/commit/3def04b11dd1ebd0a4e...
And now it works, https://project.pages.drupalcode.org/la_eu/
Closing and crediting everyone who helped out
- last update
2 days ago 73 pass - @pfrenssen opened merge request.
- 🇧🇪Belgium pjonckiere
The merge request performs some upgrades, as well as adds the needed patches to make multilingual layout builder work.
- @pjonckiere opened merge request.
- 🇧🇬Bulgaria pfrenssen Sofia
Thanks for reporting and fixing this. I will start an MR so this can be merged.
- First commit to issue fork.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
As we discussed in person, looking good but let's make it more defensive and clear that the negotiator is internal
- 🇺🇸United States xjm
@quietone raised that this would exacerbate an existing problem we have, in that our list of active subsystem maintainers is not well-maintained and we have a lot of people who have elevated permissions for Drupal core but who are not actually active as maintainers.
This is probably not blocking as it is just an extension of a problem we already have, but it does mean that it would be good to make sure that the granting and revocation of this access is automated, if possible (maybe tied to the "maintain issues" permission on the project node).
-
Grimreaper →
authored 87391036 on 8.3.x
fix(YAML): Enable YAML custom tags support (#3456991 by Grimreaper)
-
Grimreaper →
authored 87391036 on 8.3.x
- last update
2 days ago 1 pass - @brentg opened merge request.
- 🇧🇪Belgium Jonasanne
I updated the check with the correct modules and tested this again.
- Issue created by @brentg
-
tim-diels →
committed fb3805fb on 1.0.x
Issue #3457345 by tim-diels: Fix issues reported by PHPStan
-
tim-diels →
committed fb3805fb on 1.0.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@mikelutz oh I see what you are on about. We are undoing the work in 📌 StorageComparer should not wrap sourceStorage with a memory cache if it extends \Drupal\Core\Config\FileStorage Fixed - that's not good. Hmmm....
- last update
2 days ago 73 pass - last update
2 days ago 73 pass - Open on Drupal.org →Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
2 days ago Not currently mergeable. - @pfrenssen opened merge request.
- 🇧🇬Bulgaria pfrenssen Sofia
pfrenssen → changed the visibility of the branch 3423264-adding-gitlab-ci to hidden.
- 🇧🇬Bulgaria pfrenssen Sofia
Thanks for starting this! It looks like something went wrong with the MR, it is against the D7 version but this is probably by mistake.
This is something we urgently need since the DrupalCI infrastructure is going to be dismantled in a few days. I will start a new MR against D8.
- @tim-diels opened merge request.
-
tim-diels →
committed 2f9fc077 on 1.0.x
Issue #3457343 by tim-diels: Fix issues reported by CSpell
-
tim-diels →
committed 2f9fc077 on 1.0.x
- @tim-diels opened merge request.
- 🇺🇸United States mikelutz Michigan, USA
I don't want to block this, I just wanted to point it out and ask.
- 🇺🇸United States mikelutz Michigan, USA
Right, that was my question. We now get an AutoloadingStorage here. Previously we got a FileStorage, and since FileStorage has it's own static cache, we were not setting a storage cache. Now we have an AutoloadingStorage, which is based on FileStorage and uses it behind the scenes, but we are setting the storage cache as well, since it's not a FileStorage. I was wondering if we needed to. As I was stepping through HEAD and the patch trying to find the difference that caused the bug in listAll it was one of the differences I noticed, as the importer was operating on a CachedStorage object in the patch versus a FileStorage object on HEAD. It wasn't the problem, but I'm wondering if we need the sourceCacheStorage with the Autoloading storage, or if we should carve out the same exception for AutoloadingStorage here that we have carved out for FileStorage.
-
svendecabooter →
committed eac43112 on 2.0.x
Issue #3393182 by reszli: TypeError: htmlspecialchars(): Argument #1 ($...
-
svendecabooter →
committed eac43112 on 2.0.x
-
svendecabooter →
committed b7e64689 on 2.0.x
Issue #2927116 by ravi kant, Jay Jangid: Autoplay doesn't work
-
svendecabooter →
committed b7e64689 on 2.0.x
-
Grimreaper →
committed 8165979a on 1.1.x
Issue #3435933 by yassrzg, Grimreaper, pdureau: Introducing dependencies...
-
Grimreaper →
committed 8165979a on 1.1.x
-
Grimreaper →
committed 915ff981 on 1.1.x
Issue #3435933 by Grimreaper: Fix tests
-
Grimreaper →
committed 915ff981 on 1.1.x
-
svendecabooter →
committed 36f48926 on 2.0.x
Issue #3457755 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed 36f48926 on 2.0.x
-
svendecabooter →
committed 314d6837 on 8.x-1.x
Issue #3457755 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed 314d6837 on 8.x-1.x
-
pfrenssen →
committed 2cd70388 on 8.x-1.x
Issue #3457665 by pfrenssen, claudiu.cristea: Drop unsupported versions...
-
pfrenssen →
committed 2cd70388 on 8.x-1.x
- 917984d6 committed on 2.0.x
Issue #3430402: Automated Drupal 11 compatibility fixes for...
- 917984d6 committed on 2.0.x
- f320d109 committed on 2.0.x
Issue #3427421: Git repository contains a patch file
- f320d109 committed on 2.0.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@mikelutz we already get an autoloading storage here because it's getting the storage from config.storage.sync and we have test coverage in \Drupal\Tests\config\Functional\ConfigImportUITest::testEnumViaConfigImporter()
- 🇧🇪Belgium brentg Ghent
Adapted the patch with the advise of prufdloff and added the fix
- 7c8ea8ed committed on 2.0.x
Issue #3410309: Allow to hide or show autocomplete facet label
- 7c8ea8ed committed on 2.0.x
- @nlisgo opened merge request.
- 🇨🇦Canada Charlie ChX Negyesi 🍁Canada
Should the HookCollector still use hook_hook_info() to learn what files to scan? No, it shouldn't, it's not adequate, it's possible for modules/includes to include further files and those are hidden from us unless we the full scanning done here. We got our framework review, we have quite a few new things now from DevDaysBurgas, most importantly moving to a compiler pass and the introduction of LegacyHook so I think needs review is the best state right now. I will add a LegacyHook test ASAP.
- @borisson_ opened merge request.
- @svendecabooter opened merge request.
- Issue created by @svendecabooter
- 🇬🇧United Kingdom nlisgo
The reason we do not experience the issue in claro is because they have a workaround since before it was brought into Drupal core.
This is when the workaround was introduced: https://git.drupalcode.org/project/claro/-/commit/3bb63fdf6ecadd9a9ba87d...
The fix for this should also include removing that workaround code.
-
svendecabooter →
committed fe1a2722 on 1.0.x
Issue #3457623 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed fe1a2722 on 1.0.x
- Issue created by @pameeela
- 🇦🇺Australia acbramley
This will most likely be my last push on this issue. Someone else will have to pick up the torch from here on out as I've lost interest in getting it across the line due to all the rework. Unfortunately that probably means this issue is dead in the water.
I think we're going to have quite a few issues with this new approach:
1. The update path test will probably fail because the author will be set by the preSave
2. It's impossible to test that preSave because the author will be set for new blocks by the default callback
3. It's really ugly IMO. - 🇦🇺Australia acbramley
NULL seems OK if we could do it, but not sure what the implications of that are.
Doing some testing locally - I don't see any issues with leaving it NULL, the owner field is already nullable and the default value is null. That means when we install the new field (in block_content_update_10301) all existing rows get NULL as the
uid
column value. So step 1 is taken care of automatically :)Next step was to test what currently happens with existing blocks if you edit them without an author, I expected the defaultValueCallback from
EntityOwnerTrait
to kick in and set the owner to the current user, but that does not happen on update, only on insert. IMO that's good - one less thing for us to worry about overriding.(FYI That does not happen for
revision_user
- I reported this somewhere else but forgot about it, Block Content's revision_user is not set on the initial revision only on subsequent revisions. Node acts correctly so there must be some custom code doing that rather than using the default value callback. Tested MenuLinkContent as well and that has the same issue. I think 📌 Automatically set revision user/log information/created time on entity revisions Needs review will cover this)Next is to implement a preSave which sets the owner based on the initial revision's revision_user (which may be empty for some blocks because of the above, not much we can do about that though). As I'm writing this though I realise this can't use the same database queries though...
- 🇺🇸United States neclimdul Houston, TX
Not the decision maker but just going to re-iterate, I think this is a bad idea. The hacks I see for uninstalled modules seem like just the tip of the iceberg. What about removed modules. removed libraries. uninstalled themed. profiles.... it seems like a loosing battle for little benefit.
- @pfrenssen opened merge request.
- Issue created by @pfrenssen
-
pfrenssen →
committed 390c14c0 on 8.x-1.x
Issue #3438085 by pfrenssen: Support Dynamic Entity Reference 3.x
-
pfrenssen →
committed 390c14c0 on 8.x-1.x
- 🇺🇸United States smustgrave
CR reads fine, didn't know if I should remark as fixed since CR is published
-
Grimreaper →
committed f0946ce3 on 8.x-1.x
Issue #3450128 by Grimreaper, CurriedN: Check forms "(used)" feature and...
-
Grimreaper →
committed f0946ce3 on 8.x-1.x
- 🇬🇧United Kingdom longwave UK
We probably also need to be clear that this doesn't apply to preprocess hooks, nor hook_update_N or post_update hooks. Unsure if there are any other special cases on top of these?
As hook_hook_info() is gone we should remove the docs and any implementations and write a separate change record for it? Or, should the HookCollector still use hook_hook_info() to learn what files to scan?
- @grimreaper opened merge request.
- @svendecabooter opened merge request.
-
svendecabooter →
committed 878f0b51 on 2.0.x
Issue #3457614 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed 878f0b51 on 2.0.x
- Issue created by @svendecabooter
-
svendecabooter →
committed 63f3b30b on 1.0.x
Issue #3330252 by luzgallego, paraderojether: Add hook help
-
svendecabooter →
committed 63f3b30b on 1.0.x
- 🇬🇧United Kingdom longwave UK
I think this is almost ready to commit but we need to decide which branches this goes in given it has an update path (and change the deprecation messages to match).
- 🇺🇸United States mikelutz Michigan, USA
https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co.... Found this too, while I was debugging the tests? Do we need to add the Autoloading storage here?
in the Storage Comparer:
if ($source_storage instanceof FileStorage) { // FileStorage has its own static cache so that multiple reads of the // same raw configuration object are not costly. $this->sourceCacheStorage = new NullBackend('storage_comparer'); $this->sourceStorage = $source_storage; }
- 🇬🇧United Kingdom longwave UK
This looks good to me and means our YAML can be more readable instead of copy-pasting constant values around.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Discussed with @catch and @longwave - we agreed to make this change because whilst it does not fix the issue it is a better break and help module maintainers fix it quickly.
Committed and pushed e82372379d to 11.x and 1dd699f07a to 11.0.x and b8241d8c6d to 10.4.x and d0f39b40d2 to 10.3.x. Thanks!
-
alexpott →
committed e8237237 on 11.x
Issue #3441010 by catch, longwave, larowlan, dpi, dqd, geek-merlin,...
-
alexpott →
committed e8237237 on 11.x
-
alexpott →
committed 1dd699f0 on 11.0.x
Issue #3441010 by catch, longwave, larowlan, dpi, dqd, geek-merlin,...
-
alexpott →
committed 1dd699f0 on 11.0.x
-
alexpott →
committed b8241d8c on 10.4.x
Issue #3441010 by catch, longwave, larowlan, dpi, dqd, geek-merlin,...
-
alexpott →
committed b8241d8c on 10.4.x
-
alexpott →
committed d0f39b40 on 10.3.x
Issue #3441010 by catch, longwave, larowlan, dpi, dqd, geek-merlin,...
-
alexpott →
committed d0f39b40 on 10.3.x
- 🇺🇸United States mikelutz Michigan, USA
Lol, took forever to find the listAll() bug, and you fixed it before I could push :-)
- @svendecabooter opened merge request.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I've addressed @longwave's feedback - as it was all nits setting back to rtbc.
- Issue created by @svendecabooter
-
svendecabooter →
committed 001de10d on 2.0.x
Issue #3435038 by Project Update Bot, svendecabooter: Automated Drupal...
-
svendecabooter →
committed 001de10d on 2.0.x
- 🇩🇪Germany geek-merlin Freiburg, Germany
FYI but out of scope here: For my own needs i use Composable Inheritance to avoid (amongst others) this kind of pain on highly self-coupled classes that are a pain to decorate but nice to inherit.
- 🇪🇸Spain fjgarlin
Note that "gitlab_templates" support automatic GitLab pages building since this issue #3384688: Automatically publish a GitLab pages site → .
More documentation here: https://project.pages.drupalcode.org/gitlab_templates/jobs/pages/ - First commit to issue fork.
- 🇧🇪Belgium BramDriesen Belgium 🇧🇪
Adding link to slack convo ;-)
Please add credit for fjgarlin
- 🇬🇧United Kingdom longwave UK
Thanks for the discussion about this issue at Dev Days, I feel it was super productive and myself, @alexpott and @catch all agree that this is a great change and will unlock several further improvements in the future.
Added some minor feedback but overall the approach is great and I have no architectural concerns.
- First commit to issue fork.
- 🇩🇪Germany geek-merlin Freiburg, Germany
Ran into this when i had a site with hux:1.4 on core:10.3. Updating to hux:1.5 fixes the site problem.
As for MR !8558:
I reviewed the code and can confirm that it trivially implements the #30.1 proposal (single extended interface).
Requiring a test for this imho is only boilerplate.
Behavior-wise: I can confirm that adding this patch changed the core:10.3+hux:1.4 error like below:
Before:
$ drush cim [notice] There are no changes to import. PHP Fatal error: Uncaught Error: Call to undefined method Drupal\hux\HuxModuleHandler::destruct() in /home/merlin/Code/geeks4change/sites/site-h4d-greenopolis/web/core/lib/Drupal/Core/DrupalKernel.php:723
After:
$ drush cr PHP Fatal error: Class Drupal\hux\HuxModuleHandler contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Drupal\Core\DestructableInterface::destruct) in /home/merlin/Code/geeks4change/sites/site-h4d-greenopolis/web/modules/contrib/hux/src/HuxModuleHandler.php on line 21
Thus RTBC-ing.
-
pfrenssen →
committed b73b547c on 8.x-1.x
Issue #3438851 by pfrenssen: Move testing to Gitlab CI
-
pfrenssen →
committed b73b547c on 8.x-1.x
- last update
3 days ago 12 pass - 🇧🇬Bulgaria pfrenssen Sofia
The CSpell job has a failure because of a missing file, but this seems to be a bug in the Gitlab template. It is non-blocking so I am leaving it up for now.
- 🇳🇱Netherlands ekes
Switched to use GroupSitesNegotiator naming, added setting the CacheMetadata. Made this optional. These tested in the Kernel test.
Then changed the AccessPolicy to use the new Negotiator. Updated the Unit tests to reflect the changed internals, and added equivalent Unit tests for the GroupSitesNegotiator. - 🇬🇧United Kingdom alexpott 🇪🇺🌍
We have added the missing test coverage that @Wim Leers identifier - i.e. test coverage of config import containing enums for class in modules that are not yet installed.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
The tests are now fixed... sorry everyone I messed up implementing \Drupal\Core\Config\AutoloadingStorage::listAll() and didn't pass the prefix on to the underlying storage - which messed things up in a really confusing way.
- 🇬🇧United Kingdom catch
I agree 0 feels risky, not for core but in case contrib is doing something weird.
NULL seems OK if we could do it, but not sure what the implications of that are.
So checking whether we're running on a relational database or not then doing the direct update if we are seems OK compared to all the other options. I'd be OK with hard-coding mongodb in the update here if we have the follow-up to add a connection class method or similar. Or if that issue is easy to get done, we could do that first then check here (with otherwise exactly the current logic in the patch).
20 seconds for thousands of blocks is more than good enough for performance of the update so that bit is great now.
- last update
3 days ago 12 pass - last update
3 days ago Build Successful -
tim-diels →
committed ea481451 on 1.0.x
Issue #3457339 by tim-diels: Integration with Gitlab CI
-
tim-diels →
committed ea481451 on 1.0.x
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
This requires us to add something like EntityTypeExistsValidator, currently working on that.
- 🇬🇧United Kingdom longwave UK
longwave → changed the visibility of the branch 3441010-container-compile-crash to hidden.
- @longwave opened merge request.
- 🇬🇧United Kingdom longwave UK
Discussed with @alexpott at Dev Days Burgas.
We agreed that option 1 from #30 is the correct thing to do here. Under the interfaces BC policy → we are allowed to add methods to interfaces in minors where there is a 1-1 relationship with an implementation, which there is here with ModuleHandler.
We also think that this can be implemented in a 10.3.x patch release, given it is no more broken than it is already if someone is replacing the implementation of ModuleHandler with an alternative version that only implements ModuleHandlerInterface without implementing DestructableInterface as well.
-
longwave →
committed e4c14cfd on 11.x
Issue #3455110 by jagraj_singh_gill, joachim: HandlerStackConfigurator...
-
longwave →
committed e4c14cfd on 11.x
- 🇬🇧United Kingdom longwave UK
Backported down to 10.3.x as a docs-only fix.
Committed and pushed e4c14cfdd0 to 11.x and 65efa85d48 to 11.0.x and cac111ab00 to 10.4.x and 0314d83ddd to 10.3.x. Thanks!
-
longwave →
committed 65efa85d on 11.0.x
Issue #3455110 by jagraj_singh_gill, joachim: HandlerStackConfigurator...
-
longwave →
committed 65efa85d on 11.0.x
-
longwave →
committed cac111ab on 10.4.x
Issue #3455110 by jagraj_singh_gill, joachim: HandlerStackConfigurator...
-
longwave →
committed cac111ab on 10.4.x
-
longwave →
committed 0314d83d on 10.3.x
Issue #3455110 by jagraj_singh_gill, joachim: HandlerStackConfigurator...
-
longwave →
committed 0314d83d on 10.3.x
- First commit to issue fork.
-
tim-diels →
committed e098adc6 on 2.0.x authored by
p-neyens →
Issue #3393163 by p-neyens, tim-diels: Provide a correct config schema
-
tim-diels →
committed e098adc6 on 2.0.x authored by
p-neyens →
-
pfrenssen →
committed ee32ff6a on 2.x
Issue #3457570 by pfrenssen: Use Gitlab CI for linting and tests
-
pfrenssen →
committed ee32ff6a on 2.x
-
tim-diels →
committed 1afb90ba on 2.0.x authored by
p-neyens →
Issue #3393166 by p-neyens, tim-diels: Incorrect data type usage for...
-
tim-diels →
committed 1afb90ba on 2.0.x authored by
p-neyens →
- 🇺🇸United States xjm
Thanks for your patience on this issue.
I discussed this issue at Dev Davs with @catch and @daffie following discussion with @acbramley in Slack.
The new performance is great; however, the downside of the approach currently being used is that it won't work on no-SQL databases. We discussed this with @daffie and he will propose a related issue that will allow core updates to better support an SQL case and a no-SQL case.
We also discussed the proposal to set it to
0
as @Berdir suggested. We're concerned that this could have unintended side effects in edgecases or specific site configurations.If the data validation allows it to be set to
NULL
, that would be ideal. Then we can add code that happens on entity save to set a given block's author based on the first revision, so that it happens as-needed rather than in a big batch. So that's the approach we recommend (so long as it is feasible).Meanwhile, this issue has a data model improvement that should have a change record and maybe a release note. (We'll decide after the final approach whether to use the release note, but having a good release note will help us think about the impacts on site owners, code, etc. as well as edgecases.)
Leaving "Needs release manager review" pending the new approach. Thanks!
- Issue created by @pjonckiere
- @pfrenssen opened merge request.
- 🇫🇷France Grimreaper France 🇫🇷
The used is not taking extra classes into account.
- Issue created by @pfrenssen
- First commit to issue fork.
-
pfrenssen →
committed 354b155b on 2.x authored by
danrod →
Issue #3371797 by danrod, Wassilissa Elrich, Anybody, Promo-IL:...
-
pfrenssen →
committed 354b155b on 2.x authored by
danrod →
- First commit to issue fork.
- 🇧🇪Belgium tim-diels Belgium 🇧🇪
You need to use the correct module names as now we can not initiate the code anymore with wrong module names.
- 🇨🇭Switzerland dan2k3k4 Zurich
Done in Issue #3404467 via commit https://git.drupalcode.org/project/la_eu/-/commit/ce9d0d4665362083440e07...
- 🇮🇳India abhiyanshu_rawat
@tim-diels,
I have set the requirement in the module for the file. Please refer to the screenshot for more clarity. Thanks. - 🇧🇪Belgium pjonckiere
We merged the documentation that we found in the different local repos, and pushed it to the la_eu 1.0.x branch.
We will be creating follow-up tickets for the remaining things, so we have a single source of truth.
- @abhiyanshu opened merge request.
-
dan2k3k4 →
committed ce9d0d46 on 1.0.x
Fixes Issue #3404467: Add generic readme based on la_es
-
dan2k3k4 →
committed ce9d0d46 on 1.0.x
- 🇮🇳India abhiyanshu_rawat
abhiyanshu → made their first commit to this issue’s fork.
-
pfrenssen →
committed c1ee0c5d on 2.x authored by
ytsurk →
Issue #2862174 by ytsurk, Anybody: Flag for switzerland
-
pfrenssen →
committed c1ee0c5d on 2.x authored by
ytsurk →
- First commit to issue fork.
-
svendecabooter →
committed 26378df7 on 2.0.x
Issue #3457551 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed 26378df7 on 2.0.x
-
svendecabooter →
committed efd6b13b on 2.0.x
Issue #3457551 by svendecabooter: Add Gitlab CI support
-
svendecabooter →
committed efd6b13b on 2.0.x
- First commit to issue fork.
-
pfrenssen →
committed 9055ecda on 8.x-1.x
Issue #3457553 by pfrenssen: Drop support for Drupal 8
-
pfrenssen →
committed 9055ecda on 8.x-1.x
- 🇨🇭Switzerland dan2k3k4 Zurich
Adding DevDaysBurgas2024 tag as we work on this at https://ddd2024.drupalcamp.bg/
-
pfrenssen →
committed e506e01f on 8.x-1.x
Issue #3457308 by pfrenssen: Move testing to Gitlab CI
-
pfrenssen →
committed e506e01f on 8.x-1.x
- last update
3 days ago 22 pass - last update
3 days ago 22 pass - last update
3 days ago 22 pass - @pfrenssen opened merge request.
- 🇧🇪Belgium brentg Ghent
Implement the fix with the comments to fix the undefined.
There's a small issue still that I create an extra ticket for on #3457555
- Issue created by @pfrenssen
- last update
3 days ago 1 pass - @brentg opened merge request.
- last update
3 days ago Build Successful - @svendecabooter opened merge request.
- last update
3 days ago 22 pass - First commit to issue fork.
- Issue created by @svendecabooter
- last update
3 days ago 22 pass -
tim-diels →
committed 7797f4f0 on 3.0.x authored by
Jonasanne →
Issue #3445349 by Jonasanne, tim-diels: Provide icon for field overview
-
tim-diels →
committed 7797f4f0 on 3.0.x authored by
Jonasanne →
-
svendecabooter →
committed 2a263a5d on 7.x-1.x
Issue #3378253 by Zertimon, Plazik: Php 8.0 compatibility
-
svendecabooter →
committed 2a263a5d on 7.x-1.x
- Issue created by @tim-diels
- last update
3 days ago 22 pass - 🇬🇧United Kingdom alexpott 🇪🇺🌍
@longwave pointed out the adding RequestGenerator to the Utility namespace is not great. Moved to the Routing namespace as this already has:
- \Drupal\Core\Routing\RequestHelper
- \Drupal\Core\Routing\RequestFormatRouteFilter
- \Drupal\Core\Routing\RequestContext
So it not that surprising to find this there.
- last update
3 days ago 22 pass - last update
3 days ago 22 pass - 🇪🇸Spain ckrina Barcelona
This look great! Thanks for working on this and improving the UX.
-
Grimreaper →
committed 42d6ef4d on 1.0.x
Issue #3430760 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed 42d6ef4d on 1.0.x
- @grimreaper opened merge request.
-
Grimreaper →
committed f78ce59a on 8.x-1.x
Issue #3451158 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed f78ce59a on 8.x-1.x
- 🇳🇱Netherlands ekes
Logging these notes about how where we're requiring the group from context in our code base at present. Just posting here, really notes for myself about the cacheable metadata. In the interim I'd made a .module function to get the group, we're calling this, so looking at where we're using it, some are legacy, but:
Decide which page to redirect to on login
https://github.com/localgovdrupal/localgov_microsites_group/blob/98c4e17...
I don't think we mind the cacheable metadata, but we do have it from $form_state.Adding a relationship entity for content made outside the group forms on a group sites domain
https://github.com/localgovdrupal/localgov_microsites_group/blob/98c4e17...
and also legacy versions of doing that, which we can remove
https://github.com/localgovdrupal/localgov_microsites_group/blob/98c4e17...
https://github.com/localgovdrupal/localgov_microsites_group/blob/98c4e17...
Both cases, we've got the entity, so can pass the cacheable metadata from it, but don't think it makes a difference?Something clever with the Taxonomy Term form
https://github.com/localgovdrupal/localgov_microsites_group/blob/4.x/mod...
which probably will benefit from having cacheable metadata.Finally some workaround
https://github.com/localgovdrupal/localgov_microsites_group/blob/98c4e17...
where it looks like the original cache tags aren't yet correct. We can get cacheable metadata from the entity, but it's not going to make a difference here. - @tstoeckler opened merge request.
- 🇭🇺Hungary Gábor Hojtsy Hungary
In person discussion raised that this is not really a subset but more an over-arching thing that covers #3454525: [META] Track 1: Update Drupal.org for Drupal Starshot → and #3454526: [META] Track 2: Starshot product marketing section → and also informs #3454527: [META] Track 3: Drupal Starshot documentation → .
- Issue created by @tstoeckler
- 🇭🇺Hungary Gábor Hojtsy Hungary
Should this be a subissue of #3454526: [META] Track 2: Starshot product marketing section → ?
- 🇬🇧United Kingdom longwave UK
Added a change record: https://www.drupal.org/node/3457521 →
-
Grimreaper →
committed 4af2000c on 8.x-1.x
Issue #3451365 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed 4af2000c on 8.x-1.x
- @grimreaper opened merge request.
- @grimreaper opened merge request.
- 🇧🇪Belgium Jonasanne
I added the defensive check to see if menu module is enabled.
- @jonasanne opened merge request.
- 🇧🇪Belgium kristiaanvandeneynde Antwerp, Belgium
Okay I see what you're getting at now. I would approach this slightly differently, so that we don't have to repeat this code if we care about the cacheable metadata. Domain has a pretty good class/method names for this that we can mimic.
Something like: GroupSitesNegotiator::getActiveGroup($cacheable_metadata)
public function getActiveGroup(CacheableMetadata $cacheable_metadata): GroupInterface|null { $cacheable_metadata->addCacheTags(['config:group_sites.settings']) $context_id = $this->configFactory->get('group_sites.settings')->get('context_provider'); if ($context_id === NULL) { return NULL; } $contexts = $this->contextRepository->getRuntimeContexts([$context_id]); $context = count($contexts) ? reset($contexts) : NULL; if ($context) { $cacheable_metadata->addCacheableDependency($context); } $group = $context?->getContextValue(); if ($group && !$group instanceof GroupInterface) { throw new \InvalidArgumentException('Context value is not a Group entity.'); } return $group; }
Then we can inject that into GroupSitesAccessPolicy and use that there.
-
Grimreaper →
committed dfc16f5e on 1.1.x
Issue #3457507 by Grimreaper: Fix core 10.3 deprecations + use PHP...
-
Grimreaper →
committed dfc16f5e on 1.1.x
- @grimreaper opened merge request.
-
Grimreaper →
committed f7a9864b on 1.0.x
Issue #3435196 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed f7a9864b on 1.0.x
- Issue created by @pixelite
- @tstoeckler opened merge request.
- Issue created by @Grimreaper
-
longwave →
committed 3e3b4953 on 11.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave →
committed 3e3b4953 on 11.x
- 🇬🇧United Kingdom longwave UK
Backported down to 10.3.x as a tests-only change.
Committed and pushed 3e3b49539d to 11.x and 429b5dc198 to 11.0.x and b55abf3d6e to 10.4.x and 05b9d0d02b to 10.3.x. Thanks!
-
longwave →
committed 429b5dc1 on 11.0.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave →
committed 429b5dc1 on 11.0.x
-
longwave →
committed b55abf3d on 10.4.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave →
committed b55abf3d on 10.4.x
-
longwave →
committed 05b9d0d0 on 10.3.x
Issue #3452511 by pooja_sharma, joachim: convert ProviderRepositoryTest...
-
longwave →
committed 05b9d0d0 on 10.3.x
- 🇮🇹Italy mondrake 🇮🇹
Updated the main CR https://www.drupal.org/node/3365413 → to reflect this.
- @grimreaper opened merge request.
-
Grimreaper →
committed d416684e on 1.x
Issue #3451363 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed d416684e on 1.x
- 🇬🇧United Kingdom longwave UK
Backported down to 10.3.x as a docs-only fix.
Committed and pushed a9472458f9 to 11.x and cbdd92f3b3 to 11.0.x and 8ece992878 to 10.4.x and 6097bfe700 to 10.3.x. Thanks!
-
longwave →
committed a9472458 on 11.x
Issue #3456979 by joachim: add a comment to install.core.inc about the...
-
longwave →
committed a9472458 on 11.x
-
longwave →
committed cbdd92f3 on 11.0.x
Issue #3456979 by joachim: add a comment to install.core.inc about the...
-
longwave →
committed cbdd92f3 on 11.0.x
-
longwave →
committed 8ece9928 on 10.4.x
Issue #3456979 by joachim: add a comment to install.core.inc about the...
-
longwave →
committed 8ece9928 on 10.4.x
-
longwave →
committed 6097bfe7 on 10.3.x
Issue #3456979 by joachim: add a comment to install.core.inc about the...
-
longwave →
committed 6097bfe7 on 10.3.x
-
svendecabooter →
committed de8de400 on 2.0.x
Issue #3398708 by nicxvan, Frederikvho: When editing a page with an hms...
-
svendecabooter →
committed de8de400 on 2.0.x
- Issue created by @tstoeckler
-
longwave →
committed 9f6143c1 on 11.x
Issue #3453068 by kalpanajaiswal, BenStallings: Sort::fields property is...
-
longwave →
committed 9f6143c1 on 11.x
-
longwave →
committed 6f54f45d on 11.0.x
Issue #3453068 by kalpanajaiswal, BenStallings: Sort::fields property is...
-
longwave →
committed 6f54f45d on 11.0.x
-
longwave →
committed d5deca47 on 10.4.x
Issue #3453068 by kalpanajaiswal, BenStallings: Sort::fields property is...
-
longwave →
committed d5deca47 on 10.4.x
-
longwave →
committed 35848a5e on 10.3.x
Issue #3453068 by kalpanajaiswal, BenStallings: Sort::fields property is...
-
longwave →
committed 35848a5e on 10.3.x
- 🇬🇧United Kingdom longwave UK
Crediting @BenStallings for the original report and @kalpanajaiswal for the fix.
Backported down to 10.3.x as a docs-only fix.
Committed and pushed 9f6143c129 to 11.x and 6f54f45dc2 to 11.0.x and d5deca47b1 to 10.4.x and 35848a5ec5 to 10.3.x. Thanks!
- @grimreaper opened merge request.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Discussed with @catch and @longwave about whether we should put in defensive coding around broken routes and we concluded that letting Drupal error was better than either:
- Checking whether route controller exists on route build - this would result in loading too many classes into op cache
- Adding defensive coding around handling broken routes in the code here - this is likely to hide the error in a worse way that just displaying the error from PHP.
- 🇬🇧United Kingdom longwave UK
Committed and pushed 0bfc972263 to 11.x and 72601e5aef to 11.0.x. Thanks!
-
longwave →
committed 0bfc9722 on 11.x
Issue #3453341 by mondrake, alexpott, longwave: Bootstrap...
-
longwave →
committed 0bfc9722 on 11.x
-
longwave →
committed 72601e5a on 11.0.x
Issue #3453341 by mondrake, alexpott, longwave: Bootstrap...
-
longwave →
committed 72601e5a on 11.0.x
- @ekes opened merge request.
- 🇧🇪Belgium svendecabooter Gent
Thanks for the fixes!
I have done some cleanup work to avoid duplicate code.
This has now been committed. -
svendecabooter →
committed 8bbdc984 on 2.0.x authored by
jcandan →
Issue #3367474 by jcandan, angrytoast, svendecabooter: Error when trying...
-
svendecabooter →
committed 8bbdc984 on 2.0.x authored by
jcandan →
- First commit to issue fork.
-
svendecabooter →
committed 197ca926 on 2.0.x authored by
jcandan →
Issue #3351452 by jcandan, janchojnacki, clarkssquared: Argument #1 ($...
-
svendecabooter →
committed 197ca926 on 2.0.x authored by
jcandan →
-
dtfabio →
committed c8b32fd1 on 1.x authored by
PrabuEla →
Issue #3339012 by dtfabio, PrabuEla: Modify the documentation of the...
-
dtfabio →
committed c8b32fd1 on 1.x authored by
PrabuEla →
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
4 days ago Waiting for branch to pass - last update
4 days ago 22 pass - 🇧🇪Belgium Jonasanne
Jonasanne → changed the visibility of the branch 3457317-fatal-error-when to hidden.
- Issue created by @tim-diels
- Issue created by @tim-diels
- Issue created by @tim-diels
- @tim-diels opened merge request.
- Issue created by @tim-diels
- @jonasanne opened merge request.
- 🇧🇪Belgium Jonasanne
I added the icon to the field_ui form and encoded it to a base_64.
- First commit to issue fork.
-
tim-diels →
committed 09f7b2a1 on 1.0.x authored by
KevinVb →
Issue #3454592 by KevinVb, tim-diels: Allow to enable/disable...
-
tim-diels →
committed 09f7b2a1 on 1.0.x authored by
KevinVb →
- 🇬🇧United Kingdom nlisgo
I can confirm this is happening whether or not client side JS is running.
- 🇬🇧United Kingdom nlisgo
I have been able to recreate the issue in 11.x
I would like to take this on.
- 🇧🇪Belgium tim-diels Belgium 🇧🇪
I was missing the check in the local_actions_alter. So added those. Will need re-testing.
- last update
4 days ago 22 pass -
Grimreaper →
committed 1b406341 on 8.x-1.x
Issue #3435188 by Grimreaper: Automated Drupal 11 compatibility fixes...
-
Grimreaper →
committed 1b406341 on 8.x-1.x
- 🇬🇧United Kingdom longwave UK
Mistakenly removed the original tag when working on this at Dev Days.
- @grimreaper opened merge request.
- 🇺🇸United States Luke.Leber Pennsylvania
Timing on !5500 on 19621 blocks, 24290 revisions, and a batch size of 50 (default).
real 0m19.932s user 0m11.936s sys 0m0.955s
~20 seconds is a lot more acceptable than 30 minutes! What a difference the Database API makes versus the Entity API!
- last update
4 days ago 22 pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MariaDB 10.3.22last update
4 days ago Not currently mergeable. - @pfrenssen opened merge request.
- 🇬🇧United Kingdom longwave UK
I think in a followup we could even refactor that code into a static helper method on PlaceholderGenerator, so all placeholders are constructed in a consistent way.
- Issue created by @pfrenssen
- 🇫🇷France Grimreaper France 🇫🇷
PHPCS and Cspell fixed.
Remaining is PHPStan and fix PHPUnit.
-
pfrenssen →
committed 6981c1bf on 8.x-1.x
Issue #3457284 by pfrenssen: Move testing to Gitlab CI
-
pfrenssen →
committed 6981c1bf on 8.x-1.x
- last update
4 days ago 8 pass - last update
4 days ago 8 pass - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
The remaining failures are all in rest, but I don't understand how to fix them.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
4 days ago Waiting for branch to pass - @prabuela opened merge request.
- 🇳🇱Netherlands bbrala Netherlands
Yes, i think this is fine like this since it is only as docblock.
-
pfrenssen →
committed 76a0d629 on 8.x-1.x authored by
Project Update Bot →
Issue #3428329: Automated Drupal 11 compatibility fixes for...
-
pfrenssen →
committed 76a0d629 on 8.x-1.x authored by
Project Update Bot →
- last update
4 days ago 8 pass - Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MariaDB 10.3.22last update
4 days ago Not currently mergeable. - @pfrenssen opened merge request.
- Issue created by @pfrenssen
- @grimreaper opened merge request.
- last update
4 days ago 8 pass - First commit to issue fork.
-
pfrenssen →
committed 81413e92 on 8.x-1.x
Issue #3419688 by v.dovhaliuk, saidatom: Deprecated function: Return...
-
pfrenssen →
committed 81413e92 on 8.x-1.x
- Issue created by @Grimreaper
- 🇬🇧United Kingdom james.williams
Oh nice idea, thank you! Yes, I'm on board with that, I've tested my case manually too just to check, and it works fine. Combined with the automated test, I trust it's OK to put this to RTBC based on that.
If I were being really nitpicky, I'd suggest we check
Html::escape($arguments) !== ''
, since it's the escaped version that gets used, but I see we're just doing the same as inPlaceholderGenerator::createPlaceholder()
. So if that nitpick even mattered, we could just change both in a follow-up. But I'm not being nitpicky, so ignore that thought ;-) - 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Discussed with @alexpott at drupal dev days, setting default values on the entity.
- Open on Drupal.org →Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8last update
4 days ago Waiting for branch to pass - @dtfabio opened merge request.
- 🇪🇸Spain fjgarlin
The code and the new test looks good, but I'm not familiar with the testing or process for this project, so I'll leave to somebody else RTBC.
- 🇧🇪Belgium tim-diels Belgium 🇧🇪
tim-diels → changed the visibility of the branch 3445349-provide-icon-for to active.
- 🇧🇪Belgium tim-diels Belgium 🇧🇪
tim-diels → changed the visibility of the branch 3445349-provide-icon-for to hidden.
Tested the enable/disable feature provided in @KevinVb's MR. It works well for me. We can now enable or disable this functionality for menus, terms, and media as needed. Moving this to RTBC. Thanks!
- Issue created by @dtfabio
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
Looks like a lot of the current failures are because of invalid configuration in tests.
- 🇬🇧United Kingdom longwave UK
In PlaceholderGenerator we did update it to optionally output the arguments for HTML5, so I do think we should try the same here:
$placeholder_markup = '<drupal-render-placeholder callback="' . Html::escape($callback) . '"'; if ($arguments !== '') { $placeholder_markup .= ' arguments="' . Html::escape($arguments) . '"'; } $placeholder_markup .= ' token="' . Html::escape($token) . '"></drupal-render-placeholder>';
- 🇫🇷France Grimreaper France 🇫🇷
Fix + tests PR: https://github.com/pfrenssen/coder/pull/230
Tests only PR: https://github.com/pfrenssen/coder/pull/231Ready for review.
- 🇬🇧United Kingdom longwave UK
If there are no arguments, would it be better/more correct to not output the arguments attribute at all? ie. we would just have
<drupal-filter-placeholder callback="callback" token="token" />
? Then, the HTML5 parser/emitter does not need to special case this at all. - 🇫🇷France Grimreaper France 🇫🇷
So I showed the bug to @klausi, and it is definitely a real bug.
I will provide a PR with the fix on Github and we need to a failing test.
- 🇦🇺Australia pameeela
This should not be postponed as the latest comment says it can be reproduced in several core themes. Updated IS to reflect this.
- 🇺🇸United States smustgrave
Seems straight forward enough and don't think it makes it any worse.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3453068-sortfields-property-is to hidden.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3453068-property-type-update to hidden.
- Issue created by @Grimreaper
- @joachim opened merge request.
- Issue created by @joachim
- 🇧🇪Belgium kevin.vanbelle@skynet.be
Added the options to disable the modal. An option for menu, term and media is available.
I've chosen for the disable option so backward compatibility is easy, if nothing is available or configured the module will just function as is. - @kevinvb opened merge request.
- 🇧🇪Belgium kevin.vanbelle@skynet.be
KevinVb → made their first commit to this issue’s fork.