- ๐ง๐ชBelgium kristiaanvandeneynde Antwerp, Belgium
Should be all green now. Will commit and release after my vacation.
- ๐บ๐ธUnited States nicxvan
Putting back to fixed since we have a backport issue.
- ๐บ๐ธUnited States nicxvan
Backport issue ๐ Backport Hook and LegacyHook Attribute Active
- ๐ฌ๐งUnited Kingdom catch
Opened ๐ Add a feature flag for the procedural hooks bc layer Active .
- ๐บ๐ธUnited States nicxvan
Tracking the issue here: ๐ Symlinking a module breaks HookCollectorPass Active
- ๐ท๐ดRomania claudiu.cristea Arad ๐ท๐ด
It happens here https://git.drupalcode.org/project/unpublished_file/-/jobs/3102786 with PHP 8.3/11.x-dev (1b55373, which is 1 commit after c05f9be). The error is slightly different (the number of bytes differ):
Notice: file_get_contents(): Read of 8392 bytes failed with errno=21 Is a directory in /builds/project/unpublished_file/web/core/lib/Drupal/Component/Annotation/Doctrine/StaticReflectionParser.php on line 184
I can't find the error stack
- ๐จ๐ฆCanada Charlie ChX Negyesi ๐Canada
- In
HookCollectorPass::collectModuleHookImplementations
adding aif (!$fileinfo->isFile()) { continue; }
to the foreach ought to fix this - This is a php bug. RecursiveIteratorIterator defaults to LEAVES_ONLY and should not return directories.
- In
- ๐ท๐บRussia Chi
@nicxvan yes.
Stack-trace looks like follows
( [0] => Array ( [file] => /web/core/lib/Drupal/Component/Annotation/Doctrine/StaticReflectionParser.php [line] => 332 [function] => parse [class] => Drupal\Component\Annotation\Doctrine\StaticReflectionParser [type] => -> ) [1] => Array ( [file] => /web/core/lib/Drupal/Core/Hook/HookCollectorPass.php [line] => 164 [function] => getMethodAttributes [class] => Drupal\Component\Annotation\Doctrine\StaticReflectionParser [type] => -> ) [2] => Array ( [file] => /web/core/lib/Drupal/Core/Hook/HookCollectorPass.php [line] => 122 [function] => collectModuleHookImplementations [class] => Drupal\Core\Hook\HookCollectorPass [type] => -> ) [3] => Array ( [file] => /web/core/lib/Drupal/Core/Hook/HookCollectorPass.php [line] => 74 [function] => collectAllHookImplementations [class] => Drupal\Core\Hook\HookCollectorPass [type] => :: )
- ๐บ๐ธUnited States nicxvan
@chi are your tests against the next minor version too?
- ๐ท๐บRussia Chi
This somehow broke tests on a custom module. Cannot reproduce it locally, but CI output is full of such errors.
Notice: file_get_contents(): Read of 12288 bytes failed with errno=21 Is a directory in web/core/lib/Drupal/Component/Annotation/Doctrine/StaticReflectionParser.php on line 184
After some research I found a contributed module that faced same issue.
๐ phpunit (next minor) failing Active - ๐ณ๐ฑNetherlands bbrala Netherlands
Yeah alt texts would be good to add. Think we should be all ready then
- ๐ธ๐ฐSlovakia poker10
I think that the new documentation page: https://www.drupal.org/about/core/policies/maintainers/subsystem-maintainer โ (see #43 and #62).
- ๐บ๐ธUnited States smustgrave
Curious what's left to review on this since it seems things have been implemented?