Convert OpenerResolver to use a service locator

Updated title to match proposed solution

A service locator might be more optimal here, it was late when I wrote this up :)

A service locator might be more optimal here

Yeah, I kanda was wondering already why that route wasn't chosen :)
Lemme update Title/IS.

Right...

So I managed to change the title and agreeing with @longwave to use a service _locator_ and wandered off and implement a solution using a service _collector_...

*sigh*

Lemme try that again.

Spokje → changed the visibility of the branch 3421117-add-eslintrc.json-and to hidden.

Added few comments, mostly why DeprecatedServicePropertyTrait is not used in all classes?

Alternative approach in MR!6824. There are only two services that fit the pattern (and unlikely to be many more in contrib), performance doesn't seem super important here, so maybe we can just use a service collector? This requires the least code changes and as OpenerResolver is internal we can do this without providing BC - unsure why someone would want to replace this anyway.

Fixed 2 broken tests - can't get how both passed before
Filter module is required for this tests

Spokje → closed merge request !6637

OpenerResolver is tagged @internal so I think this is OK to do in 10.x for removal in 11.x with no replacement.

Assuming since it's internal it actually doesn't need to be marked, updated remaining tasks for that.

Change appears to not break anything, tested locally creating documents, images, youTube embeds, etc and no issue.

Latest approach looks fine to me and agreed with no bc for this class, extremely internal, didn't know it existed...

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

In 🐛 Adding media library openers use autoconfigure and tags in 10.3.x has BC consequences Active alexpott noted that this needs a change record.

Added a change record: https://www.drupal.org/node/3457521 →

CR reads fine, didn't know if I should remark as fixed since CR is published

Automatically closed - issue fixed for 2 weeks with no activity.