Created a MR with a rerolled version against the 6.1.x branch
brentg → changed the visibility of the branch 3352085-refactor-title-and to hidden.
I've added the patch from @sonfd as a file here so it gets listed on top of the page
Had some issues when using a link field inside layout builder on a translated page.
Issue was that the langcode was not passed along, so added a fallback for the langcode on layout builder pages
However, I have the feeling this patch is atm not the way to go as the str_pos is way too risky.
It's probably better to extend on one of the existing modules (e.g. linkit or link_field_autocomplete_filter) so that they support linking towards multiple entity types at the same time.
Patch applied for me as well.
For me the issue was introduced in #2919039, the fields I'm using are using a view instead of the default one, causing the target_bundles not to be available.
brentg → created an issue.
Going to close this issue as the module is less useful with the coming of layout builder.
Thanks for the patch, applied it
Tested this with the facets 3.x version and works indeed
Fixed in #3369399
Hi @droddis I applied the automated patch (the stable release for Drupal 10 was already available)
If you want to help with the security coverage, feel free to request it!
The access can be handled in a block_type_form_alter
e.g. a variation of the following (this was only to exclude it from the 2 column layout)
function MODULE_block_type_form_alter(array &$form, FormStateInterface &$form_state, string $block_type) {
switch ($block_type) {
case 'cb_text':
$current_section = $form_state->getFormObject()->getCurrentSection();
if ($current_section->getLayoutId() === 'rs_two_col') {
$form['field_columns']['#access'] = FALSE;
}
break;
}
}
And the class can be added as following
function MODULE_block_content_view_alter(array &$build, BlockContentInterface $entity, EntityViewDisplayInterface $display) {
if ($entity->hasField('field_columns')) {
$columns = $entity->get('field_columns')->value ?? 'one-column';
$build['#attributes']['class'][] = 'block--' . $columns;
}
}
Created a first version with just the option.
Could probably be improved with other options as well (rel nofollow, force download, ....)
Already a bunch of stuff that is working a lot cleaner, but still some issues remaining:
- When adding a block through layout builder, after adding the block, the page opens up in the layout builder iframe
- Some css improvements that where done now should be redone with the current setup
- Might be good to go over it with an ux expert to see what's still advised
Updated the default config with the schema_web_page_breadcrumb enabled.
Due to updates the order of config was also no longer correct, so that was updated as well.
Still needs to be tested on a fresh install
Added patch that works together with #3342038
brentg → created an issue.
Refactored it so that it works similar as #3342038 with multiple entity types.
smustgrave → credited brentg → .
I've added a merge request with the updated selection criteria.
TODO:
- This still needs to be tested as I've copied over the uuids that where already present
- Figure out if there's a way to fix this on existing installations.
Patch seems to work for me, so going to mark this as reviewed & tested
I encountered some issues with #55 where when saving a taxonomy term link, it was giving an unexpected error, because $node was null, so added a small extra patch that fixes this issue.
Added a merge request that will use a separate render element instead of the description of fieldsets, as this is not supported by the gin admin theme.
Added fallback for when there are no items yet.
This can happen when using layout builder blocks when you create the page and the block is added by default but not yet saved.
Added patch file for the merge request that adds this functionality.
Added patch file for the merge request that adds this functionality and also fixes issues with the placeholders for the field
quietone → credited brentg → .
Added a patch that will fix the issue For node pages.
This will probably need a test to see if this fixes it for other people as well, maybe some automated tests.
This also only fixes it for node pages, when displaying it on other entities, the issue will still happen.