Replace layout builder modal by layout builder iframe modal

Created on 22 May 2023, about 2 years ago
Updated 25 May 2023, about 2 years ago

Problem/Motivation

Layout builder modal adds an overhead because styles can be in conflict with the current theme styles. Layout builder iframe modal instead, will render that modal inside an iframe, so the admin theme will be used so no conflict with the default theme.
Other motivation to replace with layout builder iframe is to have a consistent UI, because right now the look and feel of the media library (for example) don't look the same if it's opened from the backoffice and from the layout builder.

Steps to reproduce

Proposed resolution

Replace layout_builder_modal by layout_builder_iframe_modal

Remaining tasks

  • Patch
  • Review
  • Test

User interface changes

The modals of layout builder are opened using an iframe, and rendered using the admin theme.

API changes

None

Data model changes

None

📌 Task
Status

Needs work

Version

6.0

Component

Code

Created by

🇪🇸Spain akalam

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @akalam
  • @akalam opened merge request.
  • Status changed to Needs review about 2 years ago
  • 🇪🇸Spain akalam

    Still need to implement an upgrade path, but would like to have a first review and impressions first.

  • Status changed to Needs work about 2 years ago
  • 🇧🇪Belgium brentg Ghent

    Already a bunch of stuff that is working a lot cleaner, but still some issues remaining:

    • When adding a block through layout builder, after adding the block, the page opens up in the layout builder iframe
    • Some css improvements that where done now should be redone with the current setup
    • Might be good to go over it with an ux expert to see what's still advised
  • 🇪🇸Spain akalam

    Thanks a lot Brent for your testing and feedback.

Production build 0.71.5 2024