- πΊπΈUnited States dalemoore
This is so awesome, and puts Layout Builder on closer parity with what WordPress can do with locking different parts of the Full Site Editor. I haven't tested this yet but will soon...
- π§πͺBelgium brentg Ghent
I've added the patch from @sonfd as a file here so it gets listed on top of the page
- Assigned to Chester_
- Assigned to Panchuk
- Status changed to Needs review
11 months ago 2:53pm 28 January 2024 - πΊπ¦Ukraine Panchuk Volyn, Lutsk
I want to review latest MR ASAP and deploy it in the new 2.0.x branch.
After that, we can create some RC releases with the feature.
- πΊπ¦Ukraine Panchuk Volyn, Lutsk
Okay, I finally configured the environment for the running of the tests.
I found that LayoutBuilderLockTest::testLock() fell because of the missing $blockId parameter in LayoutBuilderLockTest::checkBlockRouteAccess() method.
It looks like in Drupal 8/9 there was a way to fetch it via a magic method:
$blockId = $blockId ?? $this->body_field_block_uuid;
Going to investigate previous commits to the LayoutBuilderLockTest class, and maybe will find something related.
- πΊπ¦Ukraine Panchuk Volyn, Lutsk
Okay, finally I've fixed all the tests. The problem was with the body_field_block_uuid property, which was renamed in previous commits, but not updated in each place of code.
In addition, there were new style issues with the readme file. Disabled cspell checks for the maintainer's section.
Rewritten javascript of the module. Instead of jQuery, I used pure JS and removed outdated dependency core/jquery.
-
Panchuk β
committed 74b0f632 on 2.0.x authored by
muriqui β
Issue #3314133 by Panchuk, muriqui, Chesterr, swentel, brentg, JonZhang...
-
Panchuk β
committed 74b0f632 on 2.0.x authored by
muriqui β
- Issue was unassigned.
- Status changed to Fixed
8 months ago 8:28am 25 April 2024 - πΊπ¦Ukraine Panchuk Volyn, Lutsk
Merged into 2.x, going to create RC.
Thanks, everyone for your contribution. Automatically closed - issue fixed for 2 weeks with no activity.