🇺🇦Ukraine @Panchuk

Bot created duplicate of https://www.drupal.org/project/layout_builder_lock/issues/3431588 📌 Automated Drupal 11 compatibility fixes for layout_builder_lock Fixed

Closing it to clear backlog of Layout Builder Lock

Good news everyone, module still works on latest D11 version

panchuk → created an issue.

@codechefmarc thanks for your contribution.
I need to fix autotests first, but your MR will be reviewed and merged asap.

Fixed this bug, please review my changes.

panchuk → created an issue.

Prepared MR with fixes for a library.

panchuk → created an issue.

I made minor changes to improve the user experience of the module.
Please review and merge if everything is fine

panchuk → changed the visibility of the branch 1.0.x to hidden.

panchuk → created an issue.

Currently, I'm working with the forms steps module on the Drupal 11 website.

I haven't noticed bugs or issues, except critical errors related to the bot-generated changes.

Don't try to use merge requests or patches by bot, apply the following patch and be happy.

Added code suggested by @altcom_neil and fixed a few issues.

Next time going to add some tests, but for now it's enough.

Checked commits history and there no obvious reasons to keep 'progress' => 'null'

Fount similar problem in LayoutParagraphsBuilderForm::buildForm(). This form related to the layouts management, I'm going to add progress indicator to both forms within this issue. I'm not sure about message property, so leaving it empty for now.

panchuk → created an issue.

I installed this module on the Drupal 11 site and applied the bot-generated patch. There are a few issues that I found:

1. Missing parameters in forms
2. The "Build nester levels" feature is not working:
   1. Do not exclude entities and you will get the following error:
      Argument #1 must be of type array, null given in array_merge() (line 128 of modules/contrib/entity_references_map/src/EntityReferencesMapBuilder.php).
   2. Exclude some entities and get infinite loading of the map.

This patch is not complete, since the second issue is not fixed.

Hey @Mschuddings, thanks for your MR, and sorry for a long time without a reply

It will take me some time to review your code, BTW:
- such changes require new tests;
- coding standards issues need to be fixed;

The proposed feature sounds interesting to me, but I would like to ensure that it will be helpful to others.

@tim-diels, thanks for your MR. I can see the test has failed.

I will fix the test first and then back to this issue.

Thanks for review @Altcom_Neil

Do you want to commit these improvements/fixes? If not I'll prepare the update for MR.

Updated issue, added link to branch

Panchuk → created an issue.

I've applied a patch by the bot and ran drupal-rector check and everything looks fine. I am going to merge into 2.x and create a new RC release.

Thanks for your work @andreasderijcke. Since tests are passed and the code has no issues I decided to merge into the development branch.

I've created a new field formatter plugin according to the requirements in the issue body. Can somebody review the code and test this feature?

@Anybody I think it better to create a second formatter plugin. I'll prepare MR for this issue soon.

@Anybody Yep, using the existing formatter we can output the URL as plain text, but there is no way to choose an absolute/relative option.

Here a two options:

1) Add new options to the existing formatter plugin.
2) Create another formatter that extends FileUriFormatter logic.

Configured local environment for running tests, almost everything is okay, but there are a few tests that have fallen.

Summary of non-successful tests:

Metatag Views Basics (Drupal\Tests\metatag_views\Functional\MetatagViewsBasics)
✘ Views ui
│
│ Behat\Mink\Exception\ExpectationException: Current response status code is 404, but 200 expected.
│
│ /var/www/html/vendor/behat/mink/src/WebAssert.php:888
│ /var/www/html/vendor/behat/mink/src/WebAssert.php:145
│ /var/www/html/metatag_views/tests/src/Functional/MetatagViewsBasicsTest.php:82
│ /var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:729
│

Entity Test Metatag (Drupal\Tests\metatag\Functional\EntityTestMetatag)
↩ Post
↩ Patch
↩ Delete

Metatag Available Tokens (Drupal\Tests\metatag\FunctionalJavascript\MetatagAvailableTokens)
↩ Node metatag defaults page

Tests: 119, Assertions: 11092, Errors: 1, Skipped: 4.

Metatag Submodules Tests

• Tags (Drupal\Tests\metatag_app_links\Functional\Tags)
• Tags (Drupal\Tests\metatag_dc\Functional\Tags)
• Tags (Drupal\Tests\metatag_dc_advanced\Functional\Tags)
• Permissions (Drupal\Tests\metatag_extended_perms\Functional\Permissions)
• Tags (Drupal\Tests\metatag_facebook\Functional\Tags)
• Tags (Drupal\Tests\metatag_favicons\Functional\Tags)
• Tags (Drupal\Tests\metatag_google_cse\Functional\Tags)
• Tags (Drupal\Tests\metatag_hreflang\Functional\Tags)
• Tags (Drupal\Tests\metatag_mobile\Functional\Tags)
• Tags (Drupal\Tests\metatag_open_graph\Functional\Tags)
• Tags (Drupal\Tests\metatag_open_graph_products\Functional\Tags)
• Tags (Drupal\Tests\metatag_pinterest\Functional\Tags)
• Tags (Drupal\Tests\metatag_twitter_cards\Functional\Tags)
• Tags (Drupal\Tests\metatag_verification\Functional\Tags)

Metatag Views Tests

• Metatag Views Basics (Drupal\Tests\metatag_views\Functional\MetatagViewsBasics)
• Metatag Views Token (Drupal\Tests\metatag_views\Functional\MetatagViewsToken)

Metatag Functional Test

• Default Tags (Drupal\Tests\metatag\Functional\DefaultTags)
• Entity Test Metatag (Drupal\Tests\metatag\Functional\EntityTestMetatag)
• Language Handling (Drupal\Tests\metatag\Functional\LanguageHandling)
• Maintenance Mode (Drupal\Tests\metatag\Functional\MaintenanceMode)
• Metatag Admin (Drupal\Tests\metatag\Functional\MetatagAdmin)
• Metatag Api (Drupal\Tests\metatag\Functional\MetatagApi)
• Metatag Config Translation (Drupal\Tests\metatag\Functional\MetatagConfigTranslation)
• Metatag Custom Route (Drupal\Tests\metatag\Functional\MetatagCustomRoute)
• Metatag Field Node (Drupal\Tests\metatag\Functional\MetatagFieldNode)
• Metatag Field Term (Drupal\Tests\metatag\Functional\MetatagFieldTerm)
• Metatag Field Test (Drupal\Tests\metatag\Functional\MetatagFieldTest)
• Metatag Field User (Drupal\Tests\metatag\Functional\MetatagFieldUser)
• Metatag Forum (Drupal\Tests\metatag\Functional\MetatagForum)
• Metatag Frontpage (Drupal\Tests\metatag\Functional\MetatagFrontpage)
• Metatag Integration (Drupal\Tests\metatag\Functional\MetatagIntegration)
• Metatag Node Translation (Drupal\Tests\metatag\Functional\MetatagNodeTranslation)
• Metatag String (Drupal\Tests\metatag\Functional\MetatagString)
• Metatag Token Status (Drupal\Tests\metatag\Functional\MetatagTokenStatus)
• Metatag Token (Drupal\Tests\metatag\Functional\MetatagToken)
• Metatag Xss (Drupal\Tests\metatag\Functional\MetatagXss)
• Node Json Output (Drupal\Tests\metatag\Functional\NodeJsonOutput)
• Tags (Drupal\Tests\metatag\Functional\Tags)
• V2Updates (Drupal\Tests\metatag\Functional\Update\V2Updates)
• Metatag Available Tokens (Drupal\Tests\metatag\FunctionalJavascript\MetatagAvailableTokens)

Metatag Kernel Tests

• Metatag Settings Form (Drupal\Tests\metatag\Kernel\Form\MetatagSettingsForm)
• Metatag Manager (Drupal\Tests\metatag\Kernel\MetatagManager)
• Metatag Serialization (Drupal\Tests\metatag\Kernel\MetatagSerialization)
• Metatag Settings (Drupal\Tests\metatag\Kernel\MetatagSettings)
• Nodewords Entities (Drupal\Tests\metatag\Kernel\Migrate\d6\NodewordsEntities)
• Nodewords Field (Drupal\Tests\metatag\Kernel\Migrate\d6\NodewordsField)
• Metatag Entities (Drupal\Tests\metatag\Kernel\Migrate\d7\MetatagEntities)
• Metatag Field (Drupal\Tests\metatag\Kernel\Migrate\d7\MetatagField)
• Nodewords Field Instance (Drupal\Tests\metatag\Kernel\Plugin\migrate\source\d6\NodewordsFieldInstance)
• Metatag Field Instance (Drupal\Tests\metatag\Kernel\Plugin\migrate\source\d7\MetatagFieldInstance)

Metatag Unit Tests

• Meta Name Base (Drupal\metatag\Unit\MetaNameBase)
• Metatag Trimmer (Drupal\metatag\Unit\MetatagTrimmer)

Hey, I would like to take care of this issue and update the tests. For first I'm going to create a list of tests to update. Since there are a lot of different tests in the main module and submodules it's easy to miss something.

I successfully reproduced it on D10.1.6.

Contextual links work well for:
- Blocks from core;
- Custom blocks created not in layout;
- View blocks;

But, there are no contextual links only for inline blocks.

By the way, after some digging, I've found a related/similar issue [@3020876]

Hey, I just prepared MR for a similar issue. 'URL Only' and 'URL Plain' options are now available for the existing FieldFormatter Plugin. Probably this issue may be closed.

Refactored FieldFromatter a bit, fixed problem with missing options and coding standards issues.

Going to fix this issue. I found that DownloadLinkFieldFormatter extends LinkFormatter, so options must be available by default. Just need to update plugin base methods.

I'll take care of this issue, looks like the parent issue is close to the finish.

Merged into 2.x, going to create RC.
Thanks, everyone for your contribution.

Okay, finally I've fixed all the tests. The problem was with the body_field_block_uuid property, which was renamed in previous commits, but not updated in each place of code.

In addition, there were new style issues with the readme file. Disabled cspell checks for the maintainer's section.

Rewritten javascript of the module. Instead of jQuery, I used pure JS and removed outdated dependency core/jquery.

Okay, I finally configured the environment for the running of the tests.

I found that LayoutBuilderLockTest::testLock() fell because of the missing $blockId parameter in LayoutBuilderLockTest::checkBlockRouteAccess() method.

It looks like in Drupal 8/9 there was a way to fetch it via a magic method:

$blockId = $blockId ?? $this->body_field_block_uuid;

Going to investigate previous commits to the LayoutBuilderLockTest class, and maybe will find something related.

Patch by bot doesn't contain any fixes except an update for *.info.yml.
I'm going to merge this a bit later when the next version will be ready.

Hey @gaurav_manerkar

I don't see any problems here. This module provides a possibility to lock sections and blocks from editing, reordering, and removing. According to the locks that settled up this button may not work due to lock restrictions.

This feature was implemented a few months ago, see #3283984

If you found some bugs or issues, related to this functionality, please describe them here. Otherwise, I'm going to close the issue next week.

Thanks, and have a good day

bohart → credited Panchuk → .

I've pulled the development branch to get fixes for other tests. After that we will be able to run auto test and view correct results for this issue.

Okay, I've reviewed the merge request and fixed a few non-related to this task 'phpcs' and 'phpstan' issues.
Also, I figured out how to fix tests, so I updated them.

Thanks for your work, a lot of issues were fixed, and other issues will be finished during the next refactor of the JS part.

Thanks for your work, merge MR into the dev branch.

I want to review latest MR ASAP and deploy it in the new 2.0.x branch.

After that, we can create some RC releases with the feature.

Thanks for your work, MR looks fine.

Thanks for your work, MR looks fine.

https://git.drupalcode.org/project/paragraphs_gridstack/-/jobs/700808

https://git.drupalcode.org/project/paragraphs_gridstack/-/jobs/700809

https://git.drupalcode.org/project/paragraphs_gridstack/-/jobs/700812

Thanks for your work, MR looks great.

Thanks for your work, MR looks great.

Thanks for your work, MR looks fine.

Panchuk → created an issue.

Panchuk → created an issue.

Panchuk → created an issue.

The parent issue is close to the finish. I've decided to open this one to start work during the LutskGCW24 event.

Panchuk → created an issue.

Thanks for your work, MR looks fine.

https://git.drupalcode.org/project/paragraphs_gridstack/-/jobs/699295

Thanks for your work, MR looks fine.

https://git.drupalcode.org/project/paragraphs_gridstack/-/jobs/698826

Panchuk → created an issue.

Thanks for your work, MR looks fine.

Thank you guys for the work that you have done. I'm going to create a new release for this feature.

Reviewed as part of initiative #LutskGCW24

Reviewed as part of initiative #LutskGCW24
@Chesterr Please, take a look, and merge if there are no problems.

Solved coding standards issues and reviewed as part of initiative #LutskGCW24

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.

This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.

Panchuk → created an issue.