- Issue created by @Panchuk
- πΊπ¦Ukraine Panchuk Volyn, Lutsk
This task is scheduled for the Lutsk Global Contribution Weekend 2024, and I have already tagged it accordingly. I ask you to refrain from its implementation. Thanks for understanding.
- First commit to issue fork.
- Assigned to SmovS
- Issue was unassigned.
- Status changed to Needs review
7 months ago 9:17am 5 February 2024 - πΊπ¦Ukraine SmovS Lutsk
Hi @Panchuk
Please review my MR.
I fixed composer-lint and phpcs errors.
Also, I partly fixed eslint errors by autofix. But other ones eslint errors/warnings required a lot of JS code refactoring.
Please let me know if it is needed. - Status changed to Fixed
7 months ago 6:18pm 10 February 2024 - πΊπ¦Ukraine Panchuk Volyn, Lutsk
Okay, I've reviewed the merge request and fixed a few non-related to this task 'phpcs' and 'phpstan' issues.
Also, I figured out how to fix tests, so I updated them.Thanks for your work, a lot of issues were fixed, and other issues will be finished during the next refactor of the JS part.
-
Panchuk β
committed fda479fc on 1.0.x authored by
SmovS β
Issue #3417333 by SmovS, Panchuk: Fix eslint issues
-
Panchuk β
committed fda479fc on 1.0.x authored by
SmovS β
Automatically closed - issue fixed for 2 weeks with no activity.