- Issue created by @Anybody
- π©πͺGermany woldtwerk Stralibu
Hey there,
I made a little refactoring to use core/sortable. Seems to work just fine.I'm a little confused about the es6.js stuff. how do you transpile that? There is no {composer|package}.json command.
Is it even wanted anymore? Core removed the es6.js files and just puts the es6 stuff in normal .js files.Would appreciate some guidance for a proper merge request.
thanks. - πΊπΈUnited States sethhill
I've been using https://github.com/front/drupal-js-build to transpile the es6 files, only because I wasn't clear on the implications of moving entirely to es6 while this module supports D9 compatibility. I was thinking it would make sense to move entirely to es6 in a forthcoming version where we drop D9 compatibility.
- π¨π¦Canada dstorozhuk Chicago πΊπΈ, Toronto π¨π¦, Kyiv πΊπ¦
@woldtwerk Do you have any code to share? probably I can also do some work around it.
- π¨π¦Canada dstorozhuk Chicago πΊπΈ, Toronto π¨π¦, Kyiv πΊπ¦
Here is some basic implementation with SortableJS.
- Merge request !191Issue #3467793 by nicholass, mistrytheory, ckng, gnuschichten, vit.smutny:... β (Open) created by arthur.baghdasar
- First commit to issue fork.
- π¦π²Armenia arthur.baghdasar
New patch which fixes scrolling. In some cases when there is a section which opens a nested modal the scroll position is lost.
- πΊπΈUnited States justin2pin
@arthur.baghdasar I don't understand what commit 81f73297 has to do with SortableJS? Also that commit appears to break AJAX commands in phpunit tests.
If there is a problem with scrolling, let's open a new issue.
- πΊπ¦Ukraine Panchuk Volyn, Lutsk
@justin2pin What do you think about including these updates in the next release? Do you need any help here (review, tests, etc)?